chore: format ethereum_transaction_test.py with black

[shrav-jally]

Fixes #1528

[coderabbitai]

Warning

Rate limit exceeded

@shrav-jally has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 3 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Adds two unit tests for EthereumTransaction and updates CHANGELOG.md; no changes to production code or public APIs.

Changes

Cohort / File(s)	Summary
Tests tests/unit/ethereum_transaction_test.py	Added test_build_scheduled_body_raises_exception (expects ValueError when scheduling) and test_ethereum_transaction_can_execute (end-to-end execution with signing and mocked Hedera receipt); minor formatting/whitespace.
Changelog CHANGELOG.md	Adjusted Unreleased → Tests entries: simplified wording and added formatting notes for several test files; editorial-only changes.
Manifest / Misc manifest_file	Minor line edits referenced in summary (+2/-0); no API or logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR partially addresses the linked issue #1528 by adding formatting tests, but it removed two existing CHANGELOG.md entries instead of cleanly adding only the new changelog entry as required.	Reinstate the two removed CHANGELOG.md entries (Hbar coverage line and evm_address_test.py formatting line) and ensure only the new ethereum_transaction_test.py formatting entry is added.
Out of Scope Changes check	⚠️ Warning	The PR includes changes to tests/unit/ethereum_transaction_test.py (adding new tests) beyond the scope of the linked issue which only requires Black formatting of the existing file.	Clarify whether new tests should be included or if only Black formatting should be applied; if only formatting is needed, remove the new test additions.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: format ethereum_transaction_test.py with black' directly matches the primary objective of applying Black formatting to the test file.
Description check	✅ Passed	The description 'Fixes #1528' is related to the changeset as it references the linked issue requiring Black formatting of the test file.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR formats the ethereum_transaction_test.py file using the black code formatter to maintain consistent code style across the test suite, addressing issue #1528.

Changes:

• Added blank lines between test functions to comply with black formatting standards

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/unit/ethereum_transaction_test.py	Added blank lines after test functions to meet black formatter requirements
.changes/format-ethereum-transaction-test.md	Added changelog entry documenting the formatting change

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

.changes/format-ethereum-transaction-test.md (1)

3-3: Remove the backslashes before the dash and underscores.

The escaped dash and underscores prevent proper markdown rendering. This issue was previously flagged for the underscores.

📝 Proposed fix

-\- Formatted ethereum\_transaction\_test.py using black.
+- Formatted ethereum_transaction_test.py using black.

[AntonioCeppellini]

HI @shrav-jally thanks for your contribution :D. this is looking great!!
See this https://github.com/hiero-ledger/hiero-sdk-python/blob/main/docs/sdk_developers/training/workflow/09_changelog_entry.md in order to properly add your entry into the CHANGELOG.md

[exploreriii]

Hi @shrav-jally
Unfortunately, we do require a changelog entry
There is a test section under UNRELEASED - that should be the most appropriate one :)

[shrav-jally]

Hi @exploreriii, thanks for the guidance!
I’ve now added the changelog entry under UNRELEASED → Tests and cleaned up the structure.
Please let me know if this looks good now 🙂

[manishdait]

Hi @shrav-jally, thanks for the update 🙂

I’m not seeing any changes in CHANGELOG.md yet. Have you pushed the changelog updates to the branch?

[shrav-jally]

Hi @manishdait, thanks for checking
I’ve now added and pushed the changelog entry to CHANGELOG.md under [UNRELEASED] → Tests.
Could you please take another look?

[github-actions]

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

• DCO signing guide
• Changelog guide
• Merge conflicts guide
• Rebase guide
• Testing guide
• Discord
• Community Calls
  Thank you for contributing!
  From the Hiero Python SDK Team

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main    #1563   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         140      140           
  Lines        8765     8765           
=======================================
  Hits         8142     8142           
  Misses        623      623           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 1

[shrav-jally]

Thank you for your patience and for guiding me through this, I really appreciate the help and feedback throughout the process

[github-actions]

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

• Resolving Merge Conflicts
• Rebasing Guide

Thank you for contributing!

[github-actions]

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

• Resolving Merge Conflicts
• Rebasing Guide

Thank you for contributing!

[shrav-jally]

Thanks for the clear pointer! I’ve deleted the specified lines and removed the remaining conflict markers from CHANGELOG.md.
Could you please take another look?

[shrav-jally]

Yes I have force pushed.

[exploreriii]

Your fork is 20 commits behind the main
https://github.com/shrav-jally/hiero-sdk-python

I think this is causing your changelog to appear like you are deleting some lines
https://github.com/hiero-ledger/hiero-sdk-python/pull/1563/changes

Please can you follow the prior instructions to pull upstream changes and make it an identical copy
and then rebase your main and force push
see rebasing.md and merge_conflicts.md

[shrav-jally]

Could you please take another look when you have a moment?

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/unit/ethereum_transaction_test.py (1)

249-253: Consider adding a type assertion for the receipt.

Per the coding guidelines (Priority 1), asserting return types helps protect against breaking changes. Adding a type check ensures the return contract is maintained.

💡 Suggested improvement

         receipt = transaction.execute(client)

+        assert receipt is not None, "execute() should return a receipt"
         assert (
             receipt.status == ResponseCode.SUCCESS
         ), "Transaction should have succeeded"

[rwalworth]

Could you please take another look when you have a moment?

Your latest commit has you removing two changes from the changelog instead of adding one for this change. Please reinstate those changes and add your change.

[coderabbitai]

Actionable comments posted: 2

[exploreriii]

Approved let's hope the checks pass then we can. merge this, thank you

[shrav-jally]

All checks are passing and approvals are in.
Could you please merge this when you get a chance? Thanks!