chore: Fixed Jq syntax#1571
Conversation
Signed-off-by: mukundkumarjha <mukundiiitg@gmail.com>
WalkthroughA jq syntax error in the office hours bot script was fixed by adding a missing closing parenthesis to the jq pipeline statement that formats PR summary output. The changelog was updated to record this fix. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/scripts/bot-office-hours.sh (1)
59-59: Consider adding pagination limit togh pr list.Per coding guidelines, scripts should have bounded loops and pagination. The
gh pr listcommand could return a large number of PRs for active repositories. Consider adding--limitto bound the results.This is pre-existing behavior and outside the scope of this PR's jq fix, but worth noting for future improvement.
Optional improvement
-PR_DATA=$(gh pr list --repo "$REPO" --state open --json number,author,createdAt) +PR_DATA=$(gh pr list --repo "$REPO" --state open --limit 100 --json number,author,createdAt)
Signed-off-by: mukundkumarjha <mukundiiitg@gmail.com>
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! |
|
Hey! I took a look at this PR and the fix looks good - the missing closing parenthesis on the jq expression was definitely the cause of the syntax error. Nice catch! One small thing I noticed: the CHANGELOG entry uses backticks around the PR number ( Otherwise LGTM! |
Signed-off-by: Mukund Jha <mukundiiitg@gmail.com>
|
LGTM, recommending merge @exploreriii |
exploreriii
left a comment
There was a problem hiding this comment.
Thank you very much @mukundkumarjha and @rwalworth !
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1571 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 140 140
Lines 8765 8765
=======================================
Hits 8142 8142
Misses 623 623 🚀 New features to boost your workflow:
|
Description:
Related issue(s):
Fixes #1502
Notes for reviewer:
Checklist