Skip to content

chore: Fixed Jq syntax#1571

Merged
exploreriii merged 4 commits intohiero-ledger:mainfrom
mukundkumarjha:jan
Jan 24, 2026
Merged

chore: Fixed Jq syntax#1571
exploreriii merged 4 commits intohiero-ledger:mainfrom
mukundkumarjha:jan

Conversation

@mukundkumarjha
Copy link
Contributor

Description:

Related issue(s):

Fixes #1502

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: mukundkumarjha <mukundiiitg@gmail.com>
Signed-off-by: mukundkumarjha <mukundiiitg@gmail.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Walkthrough

A jq syntax error in the office hours bot script was fixed by adding a missing closing parenthesis to the jq pipeline statement that formats PR summary output. The changelog was updated to record this fix.

Changes

Cohort / File(s) Summary
GitHub Scripts
.github/scripts/bot-office-hours.sh
Added a missing closing parenthesis in the jq pipeline that builds the PR summary string, correcting a syntax error in PR data processing.
Changelog
CHANGELOG.md
Added an Unreleased entry documenting the jq syntax fix in bot-office-hours.sh.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR fixes the jq syntax error by adding a missing closing parenthesis in bot-office-hours.sh and includes a CHANGELOG entry, addressing the primary coding requirement from issue #1502. However, the issue requests DCO/GPG-signed commits and testing on forks—whether these were fulfilled is not evident from the provided context. Verify that commits are properly DCO and GPG-signed, and confirm manual testing was performed on a fork as specified in the acceptance criteria.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Fixed Jq syntax' is directly related to the main change: fixing a jq syntax error in the bot-office-hours.sh script by adding a missing closing parenthesis.
Description check ✅ Passed The PR description references issue #1502, which is about fixing the jq syntax error in the office hour bot script. This is related to the changeset.
Out of Scope Changes check ✅ Passed The changes are limited to fixing the jq syntax error in bot-office-hours.sh and updating CHANGELOG.md, both directly addressing issue #1502's scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/scripts/bot-office-hours.sh (1)

59-59: Consider adding pagination limit to gh pr list.

Per coding guidelines, scripts should have bounded loops and pagination. The gh pr list command could return a large number of PRs for active repositories. Consider adding --limit to bound the results.

This is pre-existing behavior and outside the scope of this PR's jq fix, but worth noting for future improvement.

Optional improvement
-PR_DATA=$(gh pr list --repo "$REPO" --state open --json number,author,createdAt)
+PR_DATA=$(gh pr list --repo "$REPO" --state open --limit 100 --json number,author,createdAt)

Signed-off-by: mukundkumarjha <mukundiiitg@gmail.com>
@github-actions
Copy link

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

Thank you for contributing!

@rwalworth
Copy link

Hey! I took a look at this PR and the fix looks good - the missing closing parenthesis on the jq expression was definitely the cause of the syntax error. Nice catch!

One small thing I noticed: the CHANGELOG entry uses backticks around the PR number (`#1502`), but the other entries in the Fixed section use plain parentheses without backticks, e.g. (#1425), (#1465). Might be worth updating for consistency.

Otherwise LGTM!

Signed-off-by: Mukund Jha <mukundiiitg@gmail.com>
@rwalworth
Copy link

LGTM, recommending merge @exploreriii

Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @mukundkumarjha and @rwalworth !

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1571   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         140      140           
  Lines        8765     8765           
=======================================
  Hits         8142     8142           
  Misses        623      623           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@exploreriii exploreriii merged commit c7f805e into hiero-ledger:main Jan 24, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Intermediate]: Fix syntax for office hour bot

3 participants