Skip to content

Conversation

@Abhijeet2409
Copy link
Contributor

@Abhijeet2409 Abhijeet2409 commented Jan 24, 2026

Changes

  • Replaced repos.checkCollaborator with repos.getCollaboratorPermissionLevel to identify repository team members.
  • Team members are now detected based on permission level (admin, write, read).

Dry run

Fixes #1568

@github-actions
Copy link

Hi @Abhijeet2409, this is **LinkBot** 👋

Linking pull requests to issues helps us significantly with reviewing pull requests and keeping the repository healthy.

🚨 This pull request does not have an issue linked.

Please link an issue using the following format:

📖 Guide:
docs/sdk_developers/how_to_link_issues.md

If no issue exists yet, please create one:
docs/sdk_developers/creating_issues.md

Thanks!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

Walkthrough

Replaces collaborator check in the GFI assignment bot script to use collaborator permission levels (repos.getCollaboratorPermissionLevel), computes an isTeamMember boolean from returned permissions, adds logging and error handling, and skips posting /assign reminders to repository collaborators. Changelog updated.

Changes

Cohort / File(s) Summary
Bot script logic
.github/scripts/bot-gfi-assign-on-comment.js
Replaced repos.checkCollaborator with repos.getCollaboratorPermissionLevel; derive isTeamMember from permission values (admin, maintain, write, read); add logging for username/permission/status; treat 403/404 as non-collaborator (log and continue) and rethrow other errors; early-return to skip /assign reminders for collaborators.
Changelog
CHANGELOG.md
Added entry noting the GFI assignment bot will skip posting /assign reminders to repository collaborators.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: replacing the permission check API to correctly detect team members.
Description check ✅ Passed The description is directly related to the changeset, explaining the API replacement and the team member detection logic based on permission levels.
Linked Issues check ✅ Passed The PR successfully implements the core requirement from #1568: preventing the GFI reminder bot from sending assignment reminders to team members by replacing the permission check API.
Out of Scope Changes check ✅ Passed All changes are within scope: the permission API replacement, team member detection logic, and changelog entry directly address issue #1568 without introducing unrelated modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@exploreriii exploreriii marked this pull request as draft January 24, 2026 12:46
@github-actions
Copy link

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

Thank you for contributing!

@aceppaluni
Copy link
Contributor

@Abhijeet2409 This is looking good!

Please be sure to address merge conflicts. If you need assistance, our team is happy to help!

@Abhijeet2409 Abhijeet2409 changed the title docs: ensure GFI reminder behavior for collaborators fix: correctly detect team members using permission level API Jan 26, 2026
@Abhijeet2409 Abhijeet2409 marked this pull request as ready for review January 26, 2026 15:16
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Signed-off-by: Abhijeet <[email protected]>
@Abhijeet2409
Copy link
Contributor Author

@exploreriii , PR is Ready for Review...

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, recommend merging @exploreriii

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1581   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         140      140           
  Lines        8765     8765           
=======================================
  Hits         8142     8142           
  Misses        623      623           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Hello, this is the OfficeHourBot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request.

Details:

Disclaimer: This is an automated reminder. Please verify the schedule here for any changes.

From,
The Python SDK Team

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@exploreriii exploreriii merged commit b64bba3 into hiero-ledger:main Jan 28, 2026
19 checks passed
@github-actions
Copy link

🎉 Congratulations on completing a beginner/Good First Issue!

Thank you for your contribution to the Hiero Python SDK! We're excited to have you as part of our community.

Here are some similar issues you might be interested in working on next:

  1. [Good First Issue]: format black tests/unit/hbar*.py

    🆕🐥 First Timers Only This issue is reserved for people who have never contributed or have made minimal contributions to Hiero Python SDK. We kno...

  2. [Good First Issue]: format black tests/unit/get_receipt_query_test.py

    🆕🐥 First Timers Only This issue is reserved for people who have never contributed or have made minimal contributions to Hiero Python SDK. We kno...

  3. [Good First Issue]: format black tests/unit/endpoint_test.py

    🆕🐥 First Timers Only This issue is reserved for people who have never contributed or have made minimal contributions to Hiero Python SDK. We kno...

  4. [Good First Issue]: format black tests/unit/custom_fee_test.py

    🆕🐥 First Timers Only This issue is reserved for people who have never contributed or have made minimal contributions to Hiero Python SDK. We kno...

  5. [Good First Issue]: format black tests/unit/crypto_utils_test.py

    🆕🐥 First Timers Only This issue is reserved for people who have never contributed or have made minimal contributions to Hiero Python SDK. We kno...

🌟 Stay connected with the project:

We look forward to seeing more contributions from you! If you have any questions, feel free to ask in our Discord community.

From the Hiero Python SDK Team 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Beginner]: Ensure that reminder workflow ignores team members

4 participants