-
Notifications
You must be signed in to change notification settings - Fork 185
fix: correctly detect team members using permission level API #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly detect team members using permission level API #1581
Conversation
Signed-off-by: Abhijeet Saharan <[email protected]>
|
Hi @Abhijeet2409, this is **LinkBot** 👋
Linking pull requests to issues helps us significantly with reviewing pull requests and keeping the repository healthy. 🚨 This pull request does not have an issue linked. Please link an issue using the following format: 📖 Guide: If no issue exists yet, please create one: Thanks! |
WalkthroughReplaces collaborator check in the GFI assignment bot script to use collaborator permission levels ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. To assist you, please read: Thank you for contributing! |
|
@Abhijeet2409 This is looking good! Please be sure to address merge conflicts. If you need assistance, our team is happy to help! |
Signed-off-by: Abhijeet Saharan <[email protected]>
Signed-off-by: Abhijeet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Signed-off-by: Abhijeet <[email protected]>
|
@exploreriii , PR is Ready for Review... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Signed-off-by: Abhijeet <[email protected]>
rwalworth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, recommend merging @exploreriii
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1581 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 140 140
Lines 8765 8765
=======================================
Hits 8142 8142
Misses 623 623 🚀 New features to boost your workflow:
|
|
Hello, this is the OfficeHourBot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here for any changes. From, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
|
🎉 Congratulations on completing a beginner/Good First Issue! Thank you for your contribution to the Hiero Python SDK! We're excited to have you as part of our community. Here are some similar issues you might be interested in working on next:
🌟 Stay connected with the project:
We look forward to seeing more contributions from you! If you have any questions, feel free to ask in our Discord community. From the Hiero Python SDK Team 🚀 |
Changes
repos.checkCollaboratorwithrepos.getCollaboratorPermissionLevelto identify repository team members.admin,write,read).Dry run
Fixes #1568