refactor: use Client.from_env() in topic_create_transaction.py #1619

gangulysiddhartha22-cmyk · 2026-01-28T08:40:35Z

Description:
Refactors to use the simpler Client.from_env()

Related issue(s):

Notes for reviewer:
The script runs successfully on testnet when OPERATOR_ID and OPERATOR_KEY are set and the account has test HBAR.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Siddhartha Ganguly <[email protected]>

coderabbitai · 2026-01-28T08:47:31Z

Walkthrough

Refactored examples/consensus/topic_create_transaction.py to initialize the client via Client.from_env() instead of manual dotenv and environment parsing. Simplified imports and updated CHANGELOG.md. Only the module-local setup_client() return annotation changed (now returns (client, client.operator_private_key)).

Changes

Cohort / File(s)	Summary
Changelog `CHANGELOG.md`	Added entry documenting refactor of `examples/consensus/topic_create_transaction.py` to use `Client.from_env()`.
Example Refactor `examples/consensus/topic_create_transaction.py`	Removed `dotenv`, `os`, `sys`, manual `OPERATOR_ID`/`OPERATOR_KEY` parsing and validation. Replaced setup with `Client.from_env()`, simplified imports to `Client`, `TopicCreateTransaction`, `ResponseCode`, `PrivateKey`. `setup_client()` now returns `(client, client.operator_private_key)` and prints network/operator info. Adjusted error/receipt handling and removed legacy environment parsing.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: refactoring to use Client.from_env() in topic_create_transaction.py.
Description check	✅ Passed	The description is directly related to the changeset, explaining the refactoring to use Client.from_env() and linking to the associated issue.
Linked Issues check	✅ Passed	The PR successfully addresses all coding requirements from `#1611`: replaced manual client setup with Client.from_env(), updated imports, removed dotenv usage, modified setup_client() function, and added CHANGELOG.md entry.
Out of Scope Changes check	✅ Passed	All changes are within scope of `#1611`: the modifications are limited to refactoring the example file and updating documentation as specified.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

examples/consensus/topic_create_transaction.py

Signed-off-by: Siddhartha Ganguly <[email protected]>

codecov · 2026-01-28T09:31:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         140      140           
  Lines        8765     8765           
=======================================
  Hits         8142     8142           
  Misses        623      623

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gangulysiddhartha22-cmyk · 2026-01-28T09:44:49Z

@rwalworth Ready for review. Thanks!

github-actions · 2026-01-28T10:11:55Z

Hello, this is the OfficeHourBot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request.

Details:

Time: 14:00 UTC
Join Link: Zoom Meeting

Disclaimer: This is an automated reminder. Please verify the schedule here for any changes.

From,
The Python SDK Team

github-actions · 2026-01-28T12:22:10Z

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

To assist you, please read:

Thank you for contributing!

Signed-off-by: gangulysiddhartha22-cmyk <[email protected]>

aceppaluni

This is looking good!

Requesting additional reviews from @hiero-ledger/hiero-sdk-python-triage

prajeeta15

this is great!
thank you so much for your contribution :D

aceppaluni · 2026-01-29T15:39:16Z

@gangulysiddhartha22-cmyk

Please be sure to address merge conflicts.
If you need assistance please reach out. We're happy to help!

Signed-off-by: gangulysiddhartha22-cmyk <[email protected]>

gangulysiddhartha22-cmyk · 2026-01-29T16:25:52Z

@aceppaluni the merge conflict has been successfully resolved using the web UI. Thank you!

rwalworth

LGTM!

exploreriii · 2026-01-30T03:21:44Z

Great work @gangulysiddhartha22-cmyk thank you again!

github-actions · 2026-01-30T03:21:54Z

🎉 Congratulations on completing a beginner/Good First Issue!

Thank you for your contribution to the Hiero Python SDK! We're excited to have you as part of our community.

Here are some beginner-level issues you might be interested in working on next:

[Beginner]: Add Missing Type Hint to to_bytes Method in Transaction Class

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....
[Beginner]: Add Missing Type Hints to sign Method in Transaction Class

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....
[Beginner]: Implement __repr__ Method for TopicId Class

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....
[Beginner]: Implement __repr__ Method for FileId Class

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....
[Beginner]: Implement __repr__ Method for NftId Class

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....

🌟 Stay connected with the project:

⭐ Star this repository to show your support
👀 Watch this repository to get notified of new issues and releases

We look forward to seeing more contributions from you! If you have any questions, feel free to ask in our Discord community.

From the Hiero Python SDK Team 🚀

use Client.from_env() in topic_create_transaction.py

dd8273e

Signed-off-by: Siddhartha Ganguly <[email protected]>

coderabbitai bot reviewed Jan 28, 2026

View reviewed changes

examples/consensus/topic_create_transaction.py Outdated Show resolved Hide resolved

examples/consensus/topic_create_transaction.py Outdated Show resolved Hide resolved

add new python modules

7935ca0

Signed-off-by: Siddhartha Ganguly <[email protected]>

gangulysiddhartha22-cmyk added 2 commits January 28, 2026 17:55

Merge branch 'main' into refactor/1611-topic-create-use-from-env

e8d20fc

Signed-off-by: gangulysiddhartha22-cmyk <[email protected]>

Merge branch 'main' into refactor/1611-topic-create-use-from-env

18d9f2b

aceppaluni reviewed Jan 28, 2026

View reviewed changes

prajeeta15 approved these changes Jan 28, 2026

View reviewed changes

Merge branch 'main' into refactor/1611-topic-create-use-from-env

224dad9

Signed-off-by: gangulysiddhartha22-cmyk <[email protected]>

rwalworth approved these changes Jan 29, 2026

View reviewed changes

exploreriii approved these changes Jan 30, 2026

View reviewed changes

exploreriii merged commit 14cda1e into hiero-ledger:main Jan 30, 2026
19 checks passed

refactor: use Client.from_env() in topic_create_transaction.py #1619

refactor: use Client.from_env() in topic_create_transaction.py #1619

Uh oh!

Conversation

gangulysiddhartha22-cmyk commented Jan 28, 2026

Uh oh!

coderabbitai bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 28, 2026

Codecov Report

Uh oh!

gangulysiddhartha22-cmyk commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

aceppaluni left a comment

Choose a reason for hiding this comment

Uh oh!

prajeeta15 left a comment

Choose a reason for hiding this comment

Uh oh!

aceppaluni commented Jan 29, 2026

Uh oh!

gangulysiddhartha22-cmyk commented Jan 29, 2026

Uh oh!

rwalworth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

exploreriii commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....

🐥 Beginner Friendly This issue is intended for contributors who have previously completed a Good First Issue in Hiero and are at a beginner level....

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Jan 28, 2026 •

edited

Loading