Skip to content

Fix Issue #745#753

Open
hannosgit wants to merge 1 commit intohierynomus:masterfrom
hannosgit:issue-745
Open

Fix Issue #745#753
hannosgit wants to merge 1 commit intohierynomus:masterfrom
hannosgit:issue-745

Conversation

@hannosgit
Copy link
Copy Markdown
Contributor

Attempts to fix issue #745 "Change mkdirs to static" with the implementation proposed in the comments of the PR.

@hannosgit hannosgit requested a review from hierynomus as a code owner March 18, 2023 18:35
@hannosgit
Copy link
Copy Markdown
Contributor Author

hannosgit commented Mar 18, 2023

Should we also create the copy method in the new util class?

@neon-dev
Copy link
Copy Markdown

neon-dev commented Apr 5, 2023

I was a bit hasty and created #757. I'd suggest implementing the pathIsFile boolean here.
Also, why not copy all the code over from SmbFiles and deprecate the old class entirely? This would also simplify deleting it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants