Refactor PuTTY Secret Key Derivation #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added KeyDerivationFunction interface for PuTTY Key Files - Moved Argon2 Key Derivation to Version 3 implementation class to separate Bouncy Castle dependency references - Replaced Bouncy Castle Hex references with ByteArrayUtils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors Secret Key Derivation for PuTTY Key Files, providing clear separation for Version 3 using Argon2 from Bouncy Castle, and Version 1 using SHA-1 with standard Java Security components.
The new interface abstraction provides clearer separation of the Version 3 implementation to avoid loading Bouncy Castle classes, unless required for Version 3 handling.
Additional changes include replacing Bouncy Castle
Hexclass references with availableByteArrayUtilsmethods.These changes maintain existing support for PuTTY Key File processing.