Rename elasticsearch_url variable #377
Merged
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable is not prefixed with the role name. In order to prevent name clashes it is renamed to zammad_elasticsearch_url.
tobiashuste
force-pushed
the
rename-variable
branch
from
809e2f8 to
9f8aaeb
Compare
Normo
approved these changes
Jan 23, 2025
Member
Normo
left a comment
Normo
left a comment
There was a problem hiding this comment.
Thanks @tobiashuste for the attention. #379 will remind us of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable is not prefixed with the role name. In order to prevent name clashes it is renamed to zammad_elasticsearch_url.