Skip to content

Use deb822_repository module to add apt repositories #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Use deb822_repository module to add apt repositories #413

merged 1 commit into from
May 22, 2025

Conversation

@Normo
Copy link
Member

@Normo Normo commented Apr 7, 2025 •
edited
Loading

  • Remove GPG keys from legacy trusted.gpg keyring
  • Use deb822_repository module to add repositories

@Normo Normo self-assigned this Apr 7, 2025
@github-actions github-actions bot added the gitlab Related to hifis.gitlab role label Apr 7, 2025
@Normo Normo force-pushed the 412-apt-key-deprecation branch 2 times, most recently from b5ab85d to 1ce2695 Compare April 7, 2025 12:51
@github-actions github-actions bot added the zammad Related to role hifis.zammad label Apr 7, 2025
@Normo Normo force-pushed the 412-apt-key-deprecation branch 2 times, most recently from 40544f0 to 5362a6f Compare April 7, 2025 13:07
@Normo Normo linked an issue May 21, 2025 that may be closed by this pull request
Fix apt-key deprecation #412
Closed
@Normo Normo added this to the v6.0.0 milestone May 21, 2025
@Normo Normo force-pushed the 412-apt-key-deprecation branch 9 times, most recently from 93a90d8 to 1856730 Compare May 21, 2025 12:37
@Normo Normo marked this pull request as ready for review May 21, 2025 12:52
@Normo Normo requested a review from a team as a code owner May 21, 2025 12:52
@Normo Normo requested a review from tobiashuste May 21, 2025 13:53
tobiashuste
tobiashuste requested changes May 22, 2025
View reviewed changes
Copy link
Member

@tobiashuste tobiashuste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.
I wonder if we should remove the previous apt files for Zammad as well.

@Normo Normo force-pushed the 412-apt-key-deprecation branch from 1856730 to 39d96ed Compare May 22, 2025 07:16
@Normo Normo requested a review from tobiashuste May 22, 2025 07:18
@Normo Normo merged commit 06ab0f0 into hifis-net:main May 22, 2025
12 checks passed
@Normo Normo deleted the 412-apt-key-deprecation branch June 2, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiashuste tobiashuste tobiashuste approved these changes

Assignees

@Normo Normo

Labels

gitlab Related to hifis.gitlab role zammad Related to role hifis.zammad

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

Fix apt-key deprecation

2 participants

@Normo @tobiashuste