higan: preliminary support for ZX Spectrum 48k & ZX Spectrum 128#144
higan: preliminary support for ZX Spectrum 48k & ZX Spectrum 128#144LukeUsher wants to merge 1 commit intohigan-emu:masterfrom
Conversation
jchv
left a comment
jchv
left a comment
There was a problem hiding this comment.
Did a preliminary, mostly-superficial sweep over the code. Looks pretty good!
|
|
||
| auto in(uint16 address) -> uint8; | ||
| auto out(uint16 address, uint8 data) -> void {} | ||
| }; No newline at end of file |
There was a problem hiding this comment.
Missing newline. Also, shouldn’t headers in Higan be .hpp?
There was a problem hiding this comment.
Good spot, will fix shortly. Old habits :p
higan/spec/tape/tape.hpp
Outdated
|
|
||
| auto save() -> void; | ||
|
|
||
| //private: |
There was a problem hiding this comment.
Guessing this is intended to be uncommented at some point?
higan/spec/ula/color.cpp
Outdated
| } | ||
|
|
||
| unreachable; | ||
| } No newline at end of file |
|
Why does this PR include the ZX Spectrum BIOS ROMs? Aren't those copyrighted? |
Amstrad gave permission for these roms to be included with emulators, many years ago, see https://groups.google.com/g/comp.sys.amstrad.8bit/c/HtpBU2Bzv_U/m/HhNDSU3MksAJ?pli=1 for details They were able to do this because Amstrad purchased the rights for the ZX Spectrum family from Sinclair way back when. (The +2 and all later models are Amstrad produced) The key point is This is why all ZX Spectrum emulators include, and are able to include the firmware/bios roms. |
|
Fair enough, though this should probably be stated somewhere in the README or something :P |
|
Status updates on this? |
Shideravan
left a comment
Shideravan
left a comment
There was a problem hiding this comment.
It's nice to see a new system coming to Higan :)
4 participants
This implements preliminary support of the ZX Spectrum 48k and ZX Spectrum 128 computers into higan.
This core should run most ZX Spectrum games without issues but may struggle with timing-sensitive homebrew and demos.
The kempston controller interface is emulated to allow joystick input in supported games.
Known Issues:
Games must be imported with Icarus and must be mono .wav (PCM) audio.