-
Notifications
You must be signed in to change notification settings - Fork 272
enhancement/highcharts-npm-scripts #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
cvasseng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for an initial solution.
Since this is using basically an FS resolver, at some point it would likely make sense to generalize things slightly (mostly the naming), and make it work with a highchartsPath option as well as the useNPM thing so that it's more practical for people to specify the exact version they want to use.
|
Hey @PaulDalek & @cvasseng, this is exactly what I need to resolve an issue I'm having with reliance on the CDN, and should reduce load on the CDN too! Is there a timeline on when this might be progressing? Thank you <3 |
Added
useNpmoption for using local Highcharts scripts.