Add find operation to FoldableOps #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyscott
reviewed
Sep 5, 2019
| F: Foldable[F]): U = | ||
| Project.collect[F, R, U, B](r)(pf) | ||
|
|
||
| def find[B](r: R)(pf: PartialFunction[R, B])(implicit F: Foldable[F]): Option[B] = |
Member
There was a problem hiding this comment.
I'd prefer the Boolean variation, as it's more consistent with find methods in the Scala stdlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
findoperation toFoldableOps, to match the first element of the structure for which the partial function passed as argument is defined.I'm not sure if this is the correct semantic of
findoperation for a givenRrecursive type. I have another implementation taking a boolean predicate likeany, oralloperations do, but then the result type offindchanges fromOption[B]toOption[R], returning the whole substructure from where the first match succeeded.I also had to add a new tag
Firstand theOptionmonoid in order to usefoldMap. Another concern is that I don't know if this shortcircuits on the first match (doesanyoperation shortcircuit?).Any feedback is more than welcome, as this is my first time working with recursion schemes concepts.