Skip to content

fix: error condition h5p_get_file_space_strategy. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1uc merged 1 commit into from
Jun 10, 2025
Merged

fix: error condition h5p_get_file_space_strategy. #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/highfive/bits/h5p_wrapper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
hbool_t* persist,
hsize_t* threshold) {
herr_t err = H5Pget_file_space_strategy(plist_id, strategy, persist, threshold);
if (err) {
HDF5ErrMapper::ToException<PropertyException>("Error setting file space strategy.");
if (err < 0) {
HDF5ErrMapper::ToException<PropertyException>("Error getting file space strategy.");

Check warning on line 36 in include/highfive/bits/h5p_wrapper.hpp

View check run for this annotation

Codecov / codecov/patch

include/highfive/bits/h5p_wrapper.hpp#L36 

Added line #L36 was not covered by tests
}

return err;
Expand Down
Loading