cleanup: remove benchmarking code. #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmarking code was made for checking a claim on a poster. It's not integrated into the CMake build-system; it doesn't use a framework; and it's not comprehensive. It was never meant to be any of those things. It's served its purpose and can now be removed.
1uc
force-pushed
the
1uc/remove-benchmarks
branch
from
68c93ef to
29ed392
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
matz-e
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarking code was made for checking a claim on a poster. It's not integrated into the CMake build-system or the CI; it doesn't use a framework; and it's not comprehensive. It was never meant to be any of those things.
It's served its purpose and can now be removed.