Skip to content

Conversation

@xuneXTW
Copy link

@xuneXTW xuneXTW commented Jun 28, 2018

Users should be shown online as long as they are active on the page.
For this reason i have added a separate config for use as "activity timeout".

@GabrielDeveloper
Copy link
Member

@xuneXTW,

Thanks for the PR, but the configuration session.lifetime is an own Laravel session config, do not make sense change because if we has a cache expiration interval biggest than session lifetime and the session expire on Laravel, on the package the user will be appear how online yet!

@xuneXTW
Copy link
Author

xuneXTW commented Jun 29, 2018

@GabrielDeveloper yes but in this case it will be an configuration issue. The thing is, most of the configurations will have an session.lifetime set to 2 hours or more. The "user-online" should display if the user is active on the page or the app, not if the user is "Logged-in" with a valid session. I use this change in my own app and it work like a charm. Everyone who want to have the user-activity-timeout set to session.lifetime can do this by setting both parameters to the same value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants