-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(rust) ensure brackets are balanced within attributes #4237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ewwwin
wants to merge
10
commits into
highlightjs:main
Choose a base branch
from
ewwwin:fix/rust-attribute-ensure-bracket-balance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
efd2417
Ensure bracket balance within attributes
ewwwin 2ca8fca
Add test cases for attribute highlighting
ewwwin 7ca8f53
Re-inline single-use mode definition
ewwwin 0aab1b0
Update CHANGES.md
ewwwin 16ce416
remove trailing commas
ewwwin 84bcd12
Merge remote-tracking branch 'upstream/main' into fix/rust-attribute-…
ewwwin 9b52109
fix other lingering trailing comma, weh
ewwwin 377a061
Merge remote-tracking branch 'upstream/main' into fix/rust-attribute-…
ewwwin 605ab42
Merge branch 'main' into fix/rust-attribute-ensure-bracket-balance
ewwwin 5a3035c
Merge branch 'main' into fix/rust-attribute-ensure-bracket-balance
ewwwin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<span class="hljs-meta">#[foo]</span> | ||
<span class="hljs-meta">#![foo]</span> | ||
|
||
<span class="hljs-meta">#[foo(bar)]</span> | ||
<span class="hljs-meta">#[foo = bar]</span> | ||
<span class="hljs-meta">#[foo(<span class="hljs-string">"a \"b\" c"</span>)]</span> | ||
<span class="hljs-meta">#[foo(bar = [a, b, c])]</span> | ||
<span class="hljs-meta">#[foo[bar]]</span> | ||
<span class="hljs-meta">#[foo{bar}]</span> | ||
|
||
<span class="hljs-meta">#![no_std]</span> | ||
<span class="hljs-meta">#[doc = <span class="hljs-string">"example"</span>]</span> | ||
<span class="hljs-meta">#[allow(unused, clippy::inline_always)]</span> | ||
<span class="hljs-meta">#[macro_use(foo, bar)]</span> | ||
<span class="hljs-meta">#[link(name = <span class="hljs-string">"CoreFoundation"</span>, kind = <span class="hljs-string">"framework"</span>)]</span> | ||
|
||
<span class="hljs-meta">#[rtic::app(device = lm3s6965, dispatchers = [UART0, UART1])]</span> | ||
<span class="hljs-meta">#[task(binds = USB_OTG1, local = [poller])]</span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#[foo] | ||
#![foo] | ||
|
||
#[foo(bar)] | ||
#[foo = bar] | ||
#[foo("a \"b\" c")] | ||
#[foo(bar = [a, b, c])] | ||
#[foo[bar]] | ||
#[foo{bar}] | ||
|
||
#![no_std] | ||
#[doc = "example"] | ||
#[allow(unused, clippy::inline_always)] | ||
#[macro_use(foo, bar)] | ||
#[link(name = "CoreFoundation", kind = "framework")] | ||
|
||
#[rtic::app(device = lm3s6965, dispatchers = [UART0, UART1])] | ||
#[task(binds = USB_OTG1, local = [poller])] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.