fix: skip re-highlighting to avoid false unescaped HTML warnings fixes #3761#4368
Open
KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
Open
fix: skip re-highlighting to avoid false unescaped HTML warnings fixes #3761#4368KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
Conversation
When highlightElement is called on already-highlighted code (e.g., consecutive hljs.highlightAll() calls), the existing <span class="hljs-*"> tags from the previous highlighting are incorrectly flagged as "unescaped HTML" - a false positive security warning. This fix checks for the data-highlighted attribute early and silently skips re-highlighting, matching the proposed solution in issue highlightjs#3761.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
highlightElementis called on already-highlighted code (e.g., consecutivehljs.highlightAll()calls), the existing<span class="hljs-*">tags from the previous highlighting are incorrectly flagged as "unescaped HTML" - a false positive security warning.Fix
This fix checks for the
data-highlightedattribute early and silently skips re-highlighting, matching the proposed solution in issue #3761.Test
The fix prevents the false warning when calling
hljs.highlightAll()multiple times on the same code blocks.Fixes #3761