Skip to content

Fixed error upon stopping recording. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexthewilde wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed error upon stopping recording. #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib-minified/WebAudioRecorder.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions lib-minified/WebAudioRecorderMp3.min.js
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions lib-minified/WebAudioRecorderOgg.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib-minified/WebAudioRecorderWav.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/WebAudioRecorderMp3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function record(buffer) {
if (bufferCount++ < maxBuffers)
if (encoder)
encoder.encode(buffer);
else
else if (recBuffers)
Copy link

@no-chris no-chris Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is wrong. You need to wrap the top level condition with brackets otherwise you will trigger a timeout with the following else.

    if (bufferCount++ < maxBuffers) {
        if (encoder)
            encoder.encode(buffer);
        else if (recBuffers)
            recBuffers.push(buffer);
    } else
        self.postMessage({ command: "timeout" });

recBuffers.push(buffer);
else
self.postMessage({ command: "timeout" });
Expand Down