Partial Implementation of fixing the typing of tests. #2563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to the fact that typing is not possible until the usages are typed.
Also remove all uses of contextlib.ExitStack in tests where simple 'with' chained blocks work Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
Signed-off-by: davfsa <[email protected]>
…into fix/typing-tests
mplatypus
added
the
skip-fragment-check
davfsa
requested changes
Oct 10, 2025
Member
davfsa
left a comment
davfsa
left a comment
There was a problem hiding this comment.
Going to really trust the testing structure here and give it a good old 👍 .
Hopefully we can keep working on this in the future, but looks good for now :)
| path: .coverage | ||
| retention-days: 1 | ||
| if-no-files-found: error | ||
| include-hidden-files: true |
Member
There was a problem hiding this comment.
Lets revert the changes in this file for now.
We can enable it in the future when it doesnt cause the pipeline to be marked as failed
|
|
||
| # Default sessions should be defined here | ||
| nox.options.sessions = ["reformat-code", "codespell", "pytest", "ruff", "slotscheck", "mypy", "verify-types"] | ||
| nox.options.sessions = [ |
Member
There was a problem hiding this comment.
I dont want it to run by default if its not something that is expected to pass as of right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This a partial implementation of the pull request 2213.
The goal of this is to make the future implementation much easier, due to the fact that "most" of the stuff has been completed.
Checklist
noxand all the pipelines have passed.