フロントエンド統合し完成させる - #100
Merged
Merged
Conversation
エンドポイントを外部から注入できるように変更
Collaborator
|
7.科目管理画面の「講義番号」入力欄は<西暦>+<6桁の番号>となるため10桁になることが確定しています,10桁以外でも登録ができてしまいます.また講義番号の最初の4桁は必ず西暦になるためそこに数字以外の文字が入力された場合その時点で間違っていることが分かります.(私の担当なのにごめんなさい))) 8.もう一度科目を登録する際は更新サイトの更新が必要である旨を表記するか,または登録ボタンを常に表示しておくのがよいと思います. |
Owner
Author
かなりナイスな指摘 |
stkiritn
previously approved these changes
Aug 14, 2026
stkiritn
left a comment
Collaborator
There was a problem hiding this comment.
これでいいと思います.102で気になったことは書いたので,approveしときます!
sunakun1331
approved these changes
Aug 14, 2026
sunakun1331
left a comment
Collaborator
There was a problem hiding this comment.
技術的な問題は見当たらないため,approveします.
hinshiba
dismissed
coderabbitai[bot]’s stale review
August 14, 2026 15:13
なぜかConversationがすべて解決されているにもかかわらずApproveしないため
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
スタックPRを完了しmainへマージする