fix: add more error handling to SNP message handler #2429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Vercel deployment URL: https://stacks-blockchain-x1z2oo60u-hirosystems.vercel.app 🚀 |
rmottley-hiro
force-pushed
the
ram/issue-2408
branch
from
0a0ac20 to
5a1eb82
Compare
rmottley-hiro
force-pushed
the
ram/issue-2408
branch
from
5a1eb82 to
2db12a1
Compare
rafaelcr
reviewed
Jan 6, 2026
rmottley-hiro
force-pushed
the
ram/issue-2408
branch
from
2db12a1 to
c42cb30
Compare
rafaelcr
approved these changes
Jan 6, 2026
Collaborator
rafaelcr
left a comment
rafaelcr
left a comment
There was a problem hiding this comment.
LGTM, just a small final question
rmottley-hiro
force-pushed
the
ram/issue-2408
branch
from
c42cb30 to
f25b112
Compare
rafaelcr
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small error handling fix while injecting SNP messages into fastify. Handle possible errors during the inject to prevent incrementing of the current block if an error occurs