Skip to content

Conversation

@pradel
Copy link
Contributor

@pradel pradel commented Jan 6, 2026

Description

Migrated Rosetta API endpoints from Express to Fastify to complete the Rosetta migration. I kept the original logic of having 2 separate Fastify servers running. Everything should work as before on the API endpoints.
To make the pr easier to review I didn't change anything in the logic, but we could now use typebox instead of the rosettaValidateRequest to get proper body types and checks.

As many changes in this pr are formatting, it should be reviewed with the "hide whitespace" option to remove the formatting changes.

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Does this introduce a breaking change?

No

Are documentation updates required?

No

Testing information

All tests should pass

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @rafaelcr or @zone117x for review

`Cannot call function on the Dummy datastore. Check if the application is running in offline mode.`
);
};
return undefined;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was making the offline tests to fail. We are now using fastify.decorate('db', datastore); and this triggers the proxy. Not sure what the best way to fix it.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant