fix: Update fetch input types to account for Request object as first … #1766
+58
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
zone117x
reviewed
Dec 16, 2024
| @@ -46,11 +52,11 @@ export async function fetchWrapper(input: RequestInfo, init?: RequestInit): Prom | |||
| return fetchResult; | |||
| } | |||
|
|
|||
| export type FetchFn = (url: string, init?: RequestInit) => Promise<Response>; | |||
| export type FetchFn = (input: RequestInfo | URL, init?: RequestInit) => Promise<Response>; | |||
There was a problem hiding this comment.
Should this just be:
export FetchFn = typeof globalThis.fetch;?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createClientapproach. Mainly for types, but also a fetch param could look different from the only string format supported currently (even though maybe this mainly already works... probably)url: fetchParams.inputso this won't impact current code (just show deprecation notice)