Skip to content

feat: Support IntegerType for unit conversions #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Support IntegerType for unit conversions #1774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/transactions/src/units.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { IntegerType, intToBigInt } from '@stacks/common';

export const MICROSTX_IN_STX = 1_000_000;

/**
Expand All @@ -9,8 +11,8 @@ export const MICROSTX_IN_STX = 1_000_000;
* microStxToStx(1000000n); // 1n
* ```
*/
export function microStxToStx(amountInMicroStx: number): number {
return amountInMicroStx / MICROSTX_IN_STX;
export function microStxToStx(amountInMicroStx: IntegerType): number {
return Number(intToBigInt(amountInMicroStx)) / MICROSTX_IN_STX;
}

/**
Expand All @@ -22,6 +24,6 @@ export function microStxToStx(amountInMicroStx: number): number {
* stxToMicroStx(1); // 1000000
* ```
*/
export function stxToMicroStx(amountInStx: number): number {
return amountInStx * MICROSTX_IN_STX;
export function stxToMicroStx(amountInStx: IntegerType): number {
return Number(intToBigInt(amountInStx)) * MICROSTX_IN_STX;
}
28 changes: 28 additions & 0 deletions packages/transactions/tests/units.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,45 @@ test(stxToMicroStx.name, () => {
expect(stxToMicroStx(1.23)).toBe(1230000);
expect(stxToMicroStx(0.000001)).toBe(1);

expect(stxToMicroStx('1')).toBe(1000000);
expect(stxToMicroStx('1.23')).toBe(1230000);
expect(stxToMicroStx('0.000001')).toBe(1);

expect(stxToMicroStx(1n)).toBe(1000000);

expect(stxToMicroStx(-1)).toBe(-1000000);
expect(stxToMicroStx(-2.34)).toBe(-2340000);
expect(stxToMicroStx(-0.000001)).toBe(-1);

expect(stxToMicroStx('-1')).toBe(-1000000);
expect(stxToMicroStx('-2.34')).toBe(-2340000);
expect(stxToMicroStx('-0.000001')).toBe(-1);

expect(stxToMicroStx(-1n)).toBe(-1000000);
});

test(microStxToStx.name, () => {
expect(microStxToStx(1000000)).toBe(1);
expect(microStxToStx(1230000)).toBe(1.23);
expect(microStxToStx(1)).toBe(0.000001);

expect(microStxToStx('1000000')).toBe(1);
expect(microStxToStx('1230000')).toBe(1.23);
expect(microStxToStx('1')).toBe(0.000001);

expect(microStxToStx(1000000n)).toBe(1);
expect(microStxToStx(1230000n)).toBe(1.23);
expect(microStxToStx(1n)).toBe(0.000001);

expect(microStxToStx(-1000000)).toBe(-1);
expect(microStxToStx(-2340000)).toBe(-2.34);
expect(microStxToStx(-1)).toBe(-0.000001);

expect(microStxToStx('-1000000')).toBe(-1);
expect(microStxToStx('-2340000')).toBe(-2.34);
expect(microStxToStx('-1')).toBe(-0.000001);

expect(microStxToStx(-1000000n)).toBe(-1);
expect(microStxToStx(-2340000n)).toBe(-2.34);
expect(microStxToStx(-1n)).toBe(-0.000001);
});
Loading