Skip to content

chore: add todo #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: add todo #1787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef982e4
chore: add todo
janniks Feb 12, 2025
08e699e
fix: Improve Address.parse helper types
janniks Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/transactions/src/namespaces/address.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,15 @@ export function parse(
| AddressString
// eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
| ContractIdString
): AddressRepr {
): Required<AddressRepr> {
const [addr, contractName] = address.split('.');
const parsed = c32addressDecode(addr);
const parsed = c32addressDecode(addr); // throws if c32 part is invalid
// todo: throw if contract name is invalid
return {
version: parsed[0],
versionChar: C32[parsed[0]],
hash160: parsed[1],
contractName: contractName,
contractName,
};
}

Expand Down
Loading