Skip to content

Fan.cs - Feature/update EC when needed (ramping up cycle); Config: Thinkpad E570 #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matkovic wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fan.cs - Feature/update EC when needed (ramping up cycle); Config: Thinkpad E570 #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83812e3
fan EC update only when needed
matkovic Mar 5, 2022
f9c398f
add thinkpad lenovo e570 config
matkovic Mar 5, 2022
66bb084
add 100 temperature fan speed threshold
matkovic Mar 6, 2022
5a9bf05
fix critical and 100 fan speed
matkovic Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions Configs/Lenovo ThinkPad E570.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
<?xml version="1.0"?>
<FanControlConfigV2 xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<NotebookModel>Lenovo Thinkpad E570</NotebookModel>
<Author>matkovic</Author>
<EcPollInterval>1000</EcPollInterval>
<ReadWriteWords>false</ReadWriteWords>
<CriticalTemperature>75</CriticalTemperature>
<FanConfigurations>
<FanConfiguration>
<ReadRegister>133</ReadRegister>
<WriteRegister>47</WriteRegister>
<MinSpeedValue>0</MinSpeedValue>
<MaxSpeedValue>64</MaxSpeedValue>
<IndependentReadMinMaxValues>true</IndependentReadMinMaxValues>
<MinSpeedValueRead>0</MinSpeedValueRead>
<MaxSpeedValueRead>72</MaxSpeedValueRead>
<ResetRequired>true</ResetRequired>
<FanSpeedResetValue>128</FanSpeedResetValue>
<FanDisplayName>System Fan</FanDisplayName>
<TemperatureThresholds>
<TemperatureThreshold>
<FanSpeed>0</FanSpeed>
<UpThreshold>0</UpThreshold>
<DownThreshold>0</DownThreshold>
</TemperatureThreshold>
<TemperatureThreshold>
<UpThreshold>50</UpThreshold>
<DownThreshold>30</DownThreshold>
<FanSpeed>4</FanSpeed>
</TemperatureThreshold>
<TemperatureThreshold>
<UpThreshold>60</UpThreshold>
<DownThreshold>50</DownThreshold>
<FanSpeed>6</FanSpeed>
</TemperatureThreshold>
<TemperatureThreshold>
<UpThreshold>70</UpThreshold>
<DownThreshold>60</DownThreshold>
<FanSpeed>8</FanSpeed>
</TemperatureThreshold>
<TemperatureThreshold>
<UpThreshold>74</UpThreshold>
<DownThreshold>73</DownThreshold>
<FanSpeed>100</FanSpeed>
</TemperatureThreshold>
</TemperatureThresholds>
<FanSpeedPercentageOverrides />
</FanConfiguration>
</FanConfigurations>
<RegisterWriteConfigurations />
</FanControlConfigV2>
5 changes: 4 additions & 1 deletion Core/StagWare.FanControl/Fan.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ internal class Fan
private readonly Dictionary<int, FanSpeedPercentageOverride> overriddenValues;

private float targetFanSpeed;
private float previousTargetFanSpeed = 0;

#endregion

Expand Down Expand Up @@ -135,7 +136,9 @@ public virtual void SetTargetSpeed(float speed, float temperature, bool readOnly

if (!readOnly)
{
ECWriteValue(PercentageToFanSpeed(speed));
if(previousTargetFanSpeed != speed)
ECWriteValue(PercentageToFanSpeed(speed));
previousTargetFanSpeed = speed;
}
}

Expand Down