Open
Conversation
- Updated ConfigurationTitle components to include data-test attributes for better testability. - Added data-test attributes to various buttons and input fields in AppColorConfigForm, HeaderConfigForm, FooterConfigForm, and FooterLinkForm for enhanced UI testing. - Updated i18n file with new POT and PO revision dates. This change aims to facilitate automated testing and improve the overall maintainability of the appearance configuration components.
Adding testing for general configuration on manager app
…aming convention - Updated various components to include data-test attributes for improved testing capabilities. - Corrected the naming convention of the application URL field from `applicationURL` to `applicationUrl`. - Updated POT and PO revision dates in the i18n file for consistency.
- Updated appearance configuration tests to include new assertions for UI elements and modal interactions. - Added data-test attributes to various components for improved testability. - Enhanced footer configuration tests to cover adding, editing, and deleting footer items and links. - Updated i18n file with new POT and PO revision dates for consistency.
# Conflicts: # apps/manager/i18n/en.pot
- Commented out existing test cases for app menu configuration to streamline the testing process. - Added a new test case for deleting an app menu item to improve coverage. - Updated the i18n file with new POT and PO revision dates for consistency. - Enhanced the AddSubMenuItem component with a data-test attribute for better testability.
…nsistency - Removed commented-out code and unnecessary comments from appearance and app menu test files to enhance readability. - Improved assertions in the appearance tests to ensure UI elements are correctly displayed. - Added error handling for missing menu items in the general tests to prevent runtime issues. - Streamlined test cases for better maintainability and clarity.
…general tests for clarity
…es for consistency - Changed the naming convention of the application URL field to ensure consistency. - Updated the POT and PO revision dates in the i18n file for accuracy.
…n i shuld click it
# Conflicts: # apps/manager/i18n/en.pot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this pull request i have added the testing for :