fix(json-imports): fix JSON import compatibility across Node versions #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The assert keyword used in JSON imports does not work with Node.js v22, causing an import error as shown in the image below.
We could have used the "with" statement instead of assert, which works in Node.js v22, but it is not supported in older Node.js versions. This would have led to compatibility issues across different versions.
Fix
Replaced all assert { type: "json" } imports with fs.readFileSync()-based JSON parsing. This method ensures compatibility with all Node.js versions, as it relies on fs.readFileSync() instead of import assertions.
Screenshot after the fix:
