Skip to content

Add an otpion to allow opcua metadata to be read#1328

Open
codepitbull wants to merge 10 commits intomasterfrom
feature/31480-opcua-metadata
Open

Add an otpion to allow opcua metadata to be read#1328
codepitbull wants to merge 10 commits intomasterfrom
feature/31480-opcua-metadata

Conversation

@codepitbull
Copy link
Copy Markdown
Contributor

Motivation

Resolves #31480

Changes

  • Add a config option to allow the retrieval of OPC UA tag metadata

@cla-bot cla-bot bot added the cla-signed label Dec 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025

Test Results

  493 files  + 3    493 suites  +3   6m 45s ⏱️ +31s
4 188 tests +34  4 185 ✅ +34  3 💤 ±0  0 ❌ ±0 
4 218 runs  +47  4 215 ✅ +47  3 💤 ±0  0 ❌ ±0 

Results for commit 0cf4a7c. ± Comparison against base commit ede03cc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025

Coverage Report

Overall Project 66.14% -0.08%
Files changed 70.14%

File Coverage
BidirectionalOpcUaSpecificAdapterConfig.java 100%
BuiltinJsonSchema.java 95.26% -0.91%
OpcUaSubscriptionLifecycleHandler.java 81.39% -0.94%
OpcUaProtocolAdapter.java 59.41% -0.58%
OpcUaToJsonConverter.java 44.63%
OpcUaSpecificAdapterConfig.java 36.14% -0.8%
NorthboundTagConsumer.java 0% -23.91%
JsonSchemaGenerator.java 0% -8.98%

@mschoenert-hivemq
Copy link
Copy Markdown
Contributor

There are a few things I would like to discuss here.

I don't understand why this is called "read-only" (not in this PR, but in the Feature request).
Certainly those properties are read-only, but many values (in OPC UA and in other protocol adapters) are read-only.
E.g. if you read the temperature from a sensor, you can't just write to that value to turn up the heat. ;-)
Unless somebody can explain to me why "read-only" makes sense,
I would suggest that we make a real effort to get rid of this misleading term!

I'm not super happy about the term Metadata either.
At least in the context of OPC UA, they never talk about these properties as metadata;
and there are other things (in the OPC UA specification) that are called metadata.

I'm also uncertain that this should be a toplevel attribute of the OPC UA configuration.
Shouldn't that rather be part of the tag definition?
E.g. as a user reading data from a OPC-UA device,
maybe I want these properties for some tags and not for others?

And finally, shouldn't we think about how this would look for other protocols?
Even if we have no plans to implement this on the current roadmap.

@marregui marregui force-pushed the feature/31480-opcua-metadata branch from 3337174 to 05173e7 Compare December 26, 2025 08:59
Copy link
Copy Markdown
Contributor

@marregui marregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@caoccao caoccao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codepitbull codepitbull force-pushed the feature/31480-opcua-metadata branch from 13646f0 to e37a169 Compare February 2, 2026 15:16
@codepitbull codepitbull force-pushed the feature/31480-opcua-metadata branch from e37a169 to a369e4d Compare February 10, 2026 17:19
Copy link
Copy Markdown
Member

@caoccao caoccao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codepitbull codepitbull force-pushed the feature/31480-opcua-metadata branch from ace1c30 to 0cf4a7c Compare February 19, 2026 08:44
@codepitbull codepitbull force-pushed the feature/31480-opcua-metadata branch from 0cf4a7c to d895b46 Compare March 3, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants