Skip to content

Comments

Improved SubAck Handling: Match packet IDs before completing event.#223

Merged
pglombardo merged 3 commits intohivemq:mainfrom
JaggerJo:fix-sub-ack-package-id-must-match-sub-request
Jan 20, 2025
Merged

Improved SubAck Handling: Match packet IDs before completing event.#223
pglombardo merged 3 commits intohivemq:mainfrom
JaggerJo:fix-sub-ack-package-id-must-match-sub-request

Conversation

@JaggerJo
Copy link
Contributor

@JaggerJo JaggerJo commented Jan 17, 2025

Description

Check Packet Identifier when waiting for Subscription Ack/Unsubscribe Ack Package. The current implementation just takes the next one and assumes this is the matching package.

Related Issue

#222

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@cla-bot
Copy link

cla-bot bot commented Jan 17, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JaggerJo on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@cla-bot
Copy link

cla-bot bot commented Jan 17, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @JaggerJo on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

@JaggerJo JaggerJo changed the title check PacketIdentifier when waiting for SubAck package. check PacketIdentifier when waiting for SubAck/UnsubAck package. Jan 17, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 20, 2025
@pglombardo
Copy link
Collaborator

Same on this PR - I'll be putting together a release soon. Thanks!

@pglombardo pglombardo changed the title check PacketIdentifier when waiting for SubAck/UnsubAck package. Improved SubAck Handling: Match packet IDs before completing event. Jan 20, 2025
@pglombardo pglombardo merged commit b4c48aa into hivemq:main Jan 20, 2025
10 checks passed
@pglombardo
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants