Skip to content

Commit 2e1719f

Browse files
authored
Merge branch 'main' into review-chapter-11
2 parents 03d4b27 + d9fe24f commit 2e1719f

35 files changed

+611
-173
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ jobs:
3333
steps:
3434
- uses: actions/checkout@v4
3535
- id: foo
36-
uses: hjwp/github-actions@v5
36+
uses: hjwp/github-actions@v6
3737
with:
3838
test_chapter: ${{ matrix.test_chapter }}

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
path = source/chapter_15_advanced_forms/superlists
3939
url = [email protected]:hjwp/book-example.git
4040
[submodule "source/chapter_14/superlists"]
41-
path = source/chapter_javascript/superlists
41+
path = source/chapter_16_javascript/superlists
4242
url = [email protected]:hjwp/book-example.git
4343
[submodule "source/chapter_15/superlists"]
4444
path = source/chapter_deploying_validation/superlists

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ build: $(HTML_PAGES) $(TMPDIR)
4747

4848

4949
.venv/bin:
50-
which uv && uv venv .venv || python -m venv .venv
50+
which uv && uv venv .venv || python3 -m venv .venv
5151
which uv && uv pip install -e . || .venv/bin/pip install -e .
5252

5353
.PHONY: install
@@ -128,9 +128,9 @@ test_chapter_14_simple_form: chapter_14_simple_form.html $(TMPDIR) .venv/bin
128128
.PHONY: test_chapter_15_advanced_forms
129129
test_chapter_15_advanced_forms: chapter_15_advanced_forms.html $(TMPDIR) .venv/bin
130130
.venv/bin/pytest -s --tb=short ./tests/test_chapter_15_advanced_forms.py
131-
.PHONY: test_chapter_javascript
132-
test_chapter_javascript: chapter_javascript.html $(TMPDIR) .venv/bin
133-
.venv/bin/pytest -s --tb=short ./tests/test_chapter_javascript.py
131+
.PHONY: test_chapter_16_javascript
132+
test_chapter_16_javascript: chapter_16_javascript.html $(TMPDIR) .venv/bin
133+
.venv/bin/pytest -s --tb=short ./tests/test_chapter_16_javascript.py
134134
.PHONY: test_chapter_deploying_validation
135135
test_chapter_deploying_validation: chapter_deploying_validation.html $(TMPDIR) .venv/bin
136136
.venv/bin/pytest -s --tb=short ./tests/test_chapter_deploying_validation.py

acknowledgments.asciidoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ Patrick Cantwell,
111111
Devin Schumacher,
112112
Nick Nielsen,
113113
Teemu Viikeri,
114+
Andrew Zipperer,
114115
and to anyone I've missed off this list,
115116
my sincere apologies, and thank you thank you once again.
116117

appendix_github_links.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Full List of Links for Each Chapter
3434
<<chapter_13_database_layer_validation>>:: https://github.com/hjwp/book-example/tree/chapter_13_database_layer_validation
3535
<<chapter_14_simple_form>>:: https://github.com/hjwp/book-example/tree/chapter_14_simple_form
3636
<<chapter_15_advanced_forms>>:: https://github.com/hjwp/book-example/tree/chapter_15_advanced_forms
37-
<<chapter_javascript>>:: https://github.com/hjwp/book-example/tree/chapter_javascript
37+
<<chapter_16_javascript>>:: https://github.com/hjwp/book-example/tree/chapter_16_javascript
3838
<<chapter_deploying_validation>>:: https://github.com/hjwp/book-example/tree/chapter_deploying_validation
3939
<<chapter_spiking_custom_auth>>:: https://github.com/hjwp/book-example/tree/chapter_spiking_custom_auth
4040
<<chapter_mocking>>:: https://github.com/hjwp/book-example/tree/chapter_mocking

appendix_rest_api.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,7 +866,7 @@ QUnit.test("should call updateItems after successful post", function (assert) {
866866
<1> First important thing to notice: We only set up our server response
867867
'after' we do the initialize. We want this to be the response to the
868868
POST request that happens on form submit, not the response to the
869-
initial GET request. (Remember our lesson from <<chapter_javascript>>?
869+
initial GET request. (Remember our lesson from <<chapter_16_javascript>>?
870870
One of the most challenging things about JS testing is controlling the
871871
order of execution.)
872872

atlas.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"chapter_13_database_layer_validation.asciidoc",
2828
"chapter_14_simple_form.asciidoc",
2929
"chapter_15_advanced_forms.asciidoc",
30-
"chapter_javascript.asciidoc",
30+
"chapter_16_javascript.asciidoc",
3131
"chapter_deploying_validation.asciidoc",
3232
"part3.asciidoc",
3333
"chapter_spiking_custom_auth.asciidoc",

book.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ include::chapter_12_organising_test_files.asciidoc[]
3737
include::chapter_13_database_layer_validation.asciidoc[]
3838
include::chapter_14_simple_form.asciidoc[]
3939
include::chapter_15_advanced_forms.asciidoc[]
40-
include::chapter_javascript.asciidoc[]
40+
include::chapter_16_javascript.asciidoc[]
4141
include::chapter_deploying_validation.asciidoc[]
4242

4343
include::part3.forbook.asciidoc[]

chapter_04_philosophy_and_refactoring.asciidoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ NOTE: This is another distinction between FTs and unit tests;
716716
we use them as the primary tool for testing our UI,
717717
and the HTML that implements it.
718718

719-
So, wanted an `<h1>`:
719+
So, we wanted an `<h1>`:
720720

721721
[role="sourcecode"]
722722
.lists/templates/home.html (ch04l008)
@@ -916,7 +916,7 @@ but it should be enough to reassure ourselves that things are working.
916916
To get that functional test to green,
917917
we then enter into the lower-level unit tests cycle,
918918
where we put together all the moving parts required,
919-
add tests for all the edge cases.
919+
and add tests for all the edge cases.
920920
Any time we get to green & refactored at the unit tests level,
921921
we can pop back up to the FT level to guide us towards the
922922
next thing we need to work.

chapter_05_post_and_database.asciidoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ def home_page(request):
355355
OK that gets our unit tests passing, but it's not really what we want.footnote:[
356356
But we _did_ learn about `request.method` and `request.POST` right?
357357
I know it might seem that I'm overdoing it,
358-
but doing things in tiny little really does have a lot of advantages,
358+
but doing things in tiny little steps really does have a lot of advantages,
359359
and one of them is that you can really think about (or in this case, learn)
360360
one thing at a time.]
361361

@@ -633,7 +633,7 @@ on applying DRY too quickly.
633633

634634

635635
Now we get to the `self.fail('Finish the test!')`.
636-
If get rid of that and finish writing our FT,
636+
If we get rid of that and finish writing our FT,
637637
to add the check for adding a second item to the table
638638
(copy and paste is our friend),
639639
we begin to see that our first cut solution really isn't going to, um, cut it:
@@ -964,7 +964,7 @@ django.db.utils.OperationalError: no such table: lists_item
964964
----
965965

966966
In Django, the ORM's job is to model and read and write from database tables,
967-
but there's a second system that's in charge,of actually _creating_
967+
but there's a second system that's in charge of actually _creating_
968968
the tables in the database called "migrations".
969969
Its job is to let you to add, remove, and modify tables and columns,
970970
based on changes you make to your _models.py_ files.

0 commit comments

Comments
 (0)