Merge pull request #229 from Enforcer/review-chapter-11

Review of chapter 11

Author: hjwp

chapter_11_ansible.asciidoc

@@ -17,6 +17,14 @@ We _could_ do all these things manually,
 but a key insight of the modern infrastructure management
 is that automation really pays off in reducing maintenance burdens.
 
+// SEBASTIAN: IMO, above statement is not strong enough (my opinion)
+//  I'd add something that software development nowadays is made in short cycles with frequent deployments
+//  and automation is a MUST - the earlier one invests into it, the faster they can focus on doing what's
+//  actually giving value.
+//
+//  ALSO... to reassure readers - automating anything requires deep understanding, so they will not miss anything.
+//  Perhaps this is even more important. When I first read this, I was like "ohhh, I'm gonna miss some fun!"
+
 It's also key to making sure our tests give us true confidence over our deployments.
 If we go to the trouble of building a staging server,footnote:[
 What I'm calling a "staging" server, some people would
@@ -152,6 +160,7 @@ They're unlikely to ever go away,
 and knowing a bit about them will get you some respect
 from all the grizzled dinosaurs out there.
 
+// SEBASTIAN: Nice, and seem-to-be timeless choice!
 
 
 ==== Spinning Up a Server
@@ -908,6 +917,11 @@ but I wanted to keep this (already long) chapter as simple as possible.
 *******************************************************************************
 
 
+// SEBASTIAN: I feel the above section would make more sense if it was mentioned waaay earlier.
+//  I must say I got lost while reading about Chef, Puppet and suddenly I see some Ansible examples
+//  without any explanation how Ansible works, any diagrams etc.
+//  I'd also appreciate seeing some example of SSH first as this is a prerequisite to
+//  using Ansible. Currently, there are too many "open loops" and I think this chapter is hard to follow.
 
 Let's run the latest version of our playbook and see how our tests get on:
 
@@ -971,6 +985,8 @@ selenium.common.exceptions.WebDriverException: Message: Reached error page:
 about:neterror?e=connectionFailure&u=http%3A//staging.ottg.co.uk/[...]
 ----
 
+// SEBASTIAN: It's awesome that by this moment by using `TEST_SERVER` one is able to run tests against "staging". Just wow!
+
 
 That `neterror` makes me think it's another networking problem.
 
@@ -1397,9 +1413,15 @@ which are a fairly typical set of steps for deployment in general
   and looking into techniques like red-green deployments.
 // CSANAD: we haven't mentioned the downtime so far
 
+// SEBASTIAN: Is red-green deployment a thing? I must admit it's the first time
+//  I see the name and so far I've only know blue-green. I also read there's red-black deployment,
+//  but am I looking for this wrong, so I cannot find anything about red-green? 🤔
+
 // TODO is there a better word than "switching across"?
 // CSANAD: I can only think of "releasing" or "deploying"
 
+// SEBASTIAN: How about simply "updating" or "changing"?
+
 Every single aspect of deployment can and probably should be automated.
 Here are a couple of general principles to think about
 when implementing infrastructure-as-code:
@@ -1415,5 +1437,6 @@ Declarative::
   rather than _how_ we should get there.
   This goes hand-in-hand with the idea of idempotence above.
 
+// SEBASTIAN: Okay, this summary is goldie 👌
 
 *******************************************************************************