Merge pull request #244 from Xronophobe/update--chapter-14_validation-first

update chapter 14

Author: hjwp

chapter_14_simple_form.asciidoc

@@ -178,9 +178,11 @@ NOTE: Doing this sort of widget customisation would get tedious
     if we had a much larger, more complex form.
     Check out
     https://django-crispy-forms.readthedocs.org/[django-crispy-forms]
-    and http://bit.ly/1rR5eyD[django-floppyforms] for some help.
     ((("django-crispy-forms")))
-    ((("django-floppyforms")))
+//CSANAD: crispy forms still seems to be maintained and up-to-date, floppyforms
+//        not so much. Some comments on floppyforms' issues say that its
+// functionality is built into Django as of 2020. I'm not sure if it's true for
+// crispyforms as well.
 
 
 [role="pagebreak-before less_space"]
@@ -535,8 +537,9 @@ the logic change:
 [subs="specialcharacters,quotes"]
 ----
 $ *git diff* # review changes in base.html, views.py and its tests
-$ *git commit -am "use new form in home_page, simplify tests. NB breaks stuff"*
+$ *git commit -am "use new form in home_page. NB breaks stuff"*
 ----
+// CSANAD: we didn't simplify the tests in this step. What's NB?
 
 
 Let's fix the functional tests.
@@ -613,6 +616,8 @@ $ *grep -r id_new_item src/lists/*
 ----
 
 Good, there are no references to `id_new_item` left.
+// CSANAD: we could mention *.pyc files under __pycache__ would probably still
+//         show up in the results.
 What about `name`/ `item_text`?
 
 [subs="specialcharacters,macros"]
@@ -645,33 +650,32 @@ Ran 17 tests in 0.126s
 OK
 ----
 
-And the functional tests too:
+And the functional tests too, where we can see three errors:
 
-[subs="specialcharacters,macros"]
 ----
-$ pass:quotes[*python src/manage.py test functional_tests*]
+ERROR: test_layout_and_styling (functional_tests.test_layout_and_styling.LayoutAndStylingTest.test_layout_and_styling)
 [...]
-  File "...goat-book/src/functional_tests/test_layout_and_styling.py", line 27,
-in test_layout_and_styling
-    inputbox = self.get_item_input_box()
-               ^^^^^^^^^^^^^^^^^^^^^^^^^
-  File "...goat-book/src/functional_tests/base.py", line 45, in
-get_item_input_box
-    return self.browser.find_element(By.ID, "id_text")
-           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+selenium.common.exceptions.NoSuchElementException: Message: Unable to locate
+element: [id="id_text"];
+[...]
+ERROR: test_can_start_a_todo_list (functional_tests.test_simple_list_creation.NewVisitorTest.test_can_start_a_todo_list)
 [...]
 selenium.common.exceptions.NoSuchElementException: Message: Unable to locate
-element: [id="id_text"]; [...]
-
+element: [id="id_text"];
 [...]
-FAILED (errors=3)
 ----
 
-Not quite!  Let's look at where this is happening--if
-you check the line number from one of the failures,
-you'll see that each time after we've submitted a first item,
-the input box has disappeared from the lists page.
+and
 
+----
+ERROR: test_cannot_add_empty_list_items (functional_tests.test_list_item_validation.ItemValidationTest.test_cannot_add_empty_list_items)
+[...]
+selenium.common.exceptions.NoSuchElementException: Message: Unable to locate
+element: .invalid-feedback;
+[...]
+----
+
+Let's start with the latter.
 Checking _views.py_ and the `new_list` view we can see
 it's because if we detect a validation error,
 we're not actually passing the form to the _home.html_ template:
@@ -1030,8 +1034,6 @@ or spin up the site manually with `manage.py runserver` if you prefer
 (see <<html5_popup_screenshot>>).
 
 
-// todo: update screenshot
-
 [[html5_popup_screenshot]]
 .HTML5 validation says no
 image::images/twp2_1401.png["The input with a popup saying 'please fill out this field'"]