Skip to content

Commit e9837c2

Browse files
committed
Merge remote-tracking branch 'rita/patch-5'
2 parents acca91e + 132a9d1 commit e9837c2

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

chapter_10_production_readiness.asciidoc

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[[chapter_10_production_readiness]]
2-
== Making our App Production-Ready
2+
== Making Our App Production-Ready
33

44
.A Note for Early Release Readers
55
****
@@ -201,7 +201,7 @@ Ran 3 tests in 10.718s
201201
OK
202202
----
203203

204-
Phew. Let's commit that
204+
Phew. Let's commit that:
205205

206206
[subs="specialcharacters,quotes"]
207207
----
@@ -387,12 +387,13 @@ See http://www.clearlytech.com/2014/01/04/12-factor-apps-plain-english/[
387387
Another common way of handling this
388388
is to have different versions of _settings.py_ for dev and prod.
389389
That can work fine too, but it can get confusing to manage.
390-
Environment variables also have the advantage of working for non-Django stuff too...
390+
Environment variables also have the advantage of working for non-Django stuff too.
391391
]
392392

393393

394394
==== Setting DEBUG=True and SECRET_KEY
395395

396+
//RITA: What do you mean by "this"? Please add a word or two for context.
396397
There's lots of ways you might do this.
397398
Here's what I propose; it may seem a little fiddly,
398399
but I'll provide a little justification for each choice.
@@ -470,7 +471,7 @@ $ pass:specialcharacters,quotes[*docker build -t superlists . && docker run \
470471
KeyError: 'DJANGO_SECRET_KEY'
471472
----
472473

473-
Ooops, and I forgot to set said secret key env var,
474+
Oops. I forgot to set said secret key env var,
474475
mere seconds after having dreamt it up!
475476

476477

@@ -505,7 +506,7 @@ AssertionError: 'To-Do' not found in 'Bad Request (400)'
505506

506507
==== ALLOWED_HOSTS is Required When Debug Mode is Turned Off
507508

508-
Not quite! Let's take a look manually: <<django-400-error>>.
509+
It's not quite working yet! Let's take a look manually: <<django-400-error>>.
509510

510511
[[django-400-error]]
511512
.An ugly 400 error
@@ -563,7 +564,7 @@ else:
563564
====
564565

565566
This is a setting that we want to change,
566-
depending on whether our docker image is running locally,
567+
depending on whether our Docker image is running locally,
567568
or on a server, so we'll use the `-e` flag again:
568569

569570

@@ -581,7 +582,7 @@ $ *docker build -t superlists . && docker run \
581582
==== Collectstatic is Required when Debug is Turned Off
582583

583584
An FT run (or just looking at the site) reveals that we've had a regression
584-
in our static files.
585+
in our static files:
585586

586587
[role="small-code"]
587588
[subs="specialcharacters,macros"]
@@ -759,7 +760,7 @@ Traceback (most recent call last):
759760
django.db.utils.OperationalError: no such table: lists_list
760761
----
761762

762-
Re-create the datase with `./src/manage.py migrate` and we'll be back to a working state.
763+
Re-create the database with `./src/manage.py migrate` and we'll be back to a working state.
763764

764765
Don't forget to commit our changes to _settings.py_,
765766
and I think we can call it job done!
@@ -768,6 +769,8 @@ when considering production-readiness,
768769
we've worked in small steps and used our tests all the way along,
769770
and we're now ready to deploy our container to a real server!
770771

772+
Find out how, in our next exciting installment...
773+
771774

772775
[role="pagebreak-before less_space"]
773776
.Production-Readiness Config

0 commit comments

Comments
 (0)