Skip to content

Conversation

@sujit-168
Copy link

@sujit-168 sujit-168 commented Mar 3, 2025

@sujit-168 sujit-168 force-pushed the humble branch 2 times, most recently from 8bc59f9 to fe99cc2 Compare March 5, 2025 15:38
@james-ward
Copy link

@sujit-168 I have added a couple of new commits to your work, so that the parameters are set on the main node properly:
https://github.com/integralrobotics/FAST-LIVO2

Also, your version of Vikit isn't public, so the version I have compiled against is here: https://github.com/integralrobotics/rpg_vikit.git

I was thinking about modernising the CMakeLists.txt file to use a cleaner approach, if you are interested in that as well.

@sujit-168
Copy link
Author

@james-ward Thank you for contributing to this pull request, especially for open-sourcing your completely modified solution. Your modifications to Vikit are another interesting approach.

@james-ward
Copy link

I have put in a PR to your original branch: Robotic-Developer-Road#1

@sujit-168
Copy link
Author

@james-ward Regarding the way to read camera parameters, my suggestion is to keep two solutions so that the community can refer to them. This issue can have more discussions.

@james-ward
Copy link

@james-ward Regarding the way to read camera parameters, my suggestion is to keep two solutions so that the community can refer to them. This issue can have more discussions.

Sure. But until you release the version of Vikit you are using I couldn't get your method to work.

@biggiantpigeon
Copy link

@sujit-168 I have added a couple of new commits to your work, so that the parameters are set on the main node properly: https://github.com/integralrobotics/FAST-LIVO2

Also, your version of Vikit isn't public, so the version I have compiled against is here: https://github.com/integralrobotics/rpg_vikit.git

I was thinking about modernising the CMakeLists.txt file to use a cleaner approach, if you are interested in that as well.

Thank for the work, I have some trouble with sophus -- fast-livo2 demand sophus on a specific commit, but vikit seems cannot build with that, se3 is .h for fast-livo2 and .hpp for vikit. Can you share which sophus version you are using?

@sujit-168
Copy link
Author

@biggiantpigeon you can find it in README.md

@james-ward
Copy link

@sujit-168 I have added a couple of new commits to your work, so that the parameters are set on the main node properly: https://github.com/integralrobotics/FAST-LIVO2
Also, your version of Vikit isn't public, so the version I have compiled against is here: https://github.com/integralrobotics/rpg_vikit.git
I was thinking about modernising the CMakeLists.txt file to use a cleaner approach, if you are interested in that as well.

Thank for the work, I have some trouble with sophus -- fast-livo2 demand sophus on a specific commit, but vikit seems cannot build with that, se3 is .h for fast-livo2 and .hpp for vikit. Can you share which sophus version you are using?

My version just uses the current version in the Ubuntu APT repo.

@biggiantpigeon
Copy link

@biggiantpigeon you can find it in README.md

I use method mentioned in #128 (comment) and it works, maybe consider update sophus part in readme~

@sujit-168
Copy link
Author

@biggiantpigeon you can find it in README.md

I use method mentioned in #128 (comment) and it works, maybe consider update sophus part in readme~

OK, this way will be updated in README.md

@sujit-168
Copy link
Author

@james-ward Regarding the way to read camera parameters, my suggestion is to keep two solutions so that the community can refer to them. This issue can have more discussions.

Sure. But until you release the version of Vikit you are using I couldn't get your method to work.

The rpg_vikit module I used is now open-source, and FAST-LIVO2 will soon be updated with the latest upstream modifications from the HKU-MARS lab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants