Use configurable voxel_size in plane queries (vio.cpp) #352
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is problem?
Hello
I think your code is really great.
While reading through code, I found one issue:
In
vio.cpp, thevoxel_sizefor the plane map query is set to0.5,which can be different from the value set in the config file.
Thus, I have updated the code so that
vio.cppuses thevoxel_sizespecified invoxel_map.Thank you.
Modified Files
vio.cpp: Update the plane query to utilize theplane_voxel_sizevio.h: Define the variableplane_voxel_sizeLVIMapper.cpp: Initialize the variableplane_voxel_size