Conversation
|
I've resolved the merge conflicts since this got out of date, any further changes needed? |
|
@steveswinsburg - which HL7 AU projects is this test for? |
| "code": "AMB", | ||
| "display": "ambulatory" | ||
| }, | ||
| "type": [ |
There was a problem hiding this comment.
Encounter.type is not mandatory/MS in AU Core Encounter. Is there a reason for this to be included in the example?
There was a problem hiding this comment.
As an implementor, realistic test data is more useful than just the minimum set of MS elements as systems should still be able to receive additional fields without falling over. However I have removed it.
| "period": { | ||
| "start": "2022-04-11T09:20:00+10:00", | ||
| "end": "2022-04-11T09:35:00+10:00" | ||
| }, |
There was a problem hiding this comment.
It's recommended that test data cover Must Support elements. The following are missing from these examples:
- reasonCode: Coded reason the encounter takes place
- reasonReference: Reason the encounter takes place (reference)
- location : Location the encounter took place
There was a problem hiding this comment.
Thanks, will add.
There was a problem hiding this comment.
reasonCode and location are straightforward. reasonReference is more tricky since there isn't an existing Condition that can be used as a reason for a flu vaccination so I created two that can be used that make sense for this (immunocompromised and chronic asthma)
| "code": "AMB", | ||
| "display": "ambulatory" | ||
| }, | ||
| "type": [ |
There was a problem hiding this comment.
Suggest type is removed for 2 reasons:
- type is not MS or mandatory
- Vaccinia is a Smallpox immunization and the serviceType/id/file name suggest this is an Influenza vaccination encounter.
There was a problem hiding this comment.
Have removed type from all encounters
| "start": "2023-04-11T09:20:00+10:00", | ||
| "end": "2023-04-11T09:35:00+10:00" | ||
| }, | ||
| "serviceProvider": { |
There was a problem hiding this comment.
See my comments in Encounter influenza admin 1 regarding missing MS elements reasonCode, reasonReference and location.
| "code": "AMB", | ||
| "display": "ambulatory" | ||
| }, | ||
| "type": [ |
There was a problem hiding this comment.
Suggest type is removed for 2 reasons:
- type is not MS or mandatory
- Vaccinia is a Smallpox immunization and the serviceType/id/file name suggest this is an Influenza vaccination encounter.
| "period": { | ||
| "start": "2025-04-11T09:20:00+10:00", | ||
| "end": "2025-04-11T09:35:00+10:00" | ||
| }, |
There was a problem hiding this comment.
See my comments in Encounter influenza admin 1 regarding missing MS elements reasonCode, reasonReference and location.
| "code": "AMB", | ||
| "display": "ambulatory" | ||
| }, | ||
| "type": [ |
There was a problem hiding this comment.
Suggest type is removed for 2 reasons:
- type is not MS or mandatory
- Vaccinia is a Smallpox immunization and the serviceType/id/file name suggest this is an Influenza vaccination encounter.
| "period": { | ||
| "start": "2022-04-11T09:20:00+10:00", | ||
| "end": "2022-04-11T09:35:00+10:00" | ||
| }, |
There was a problem hiding this comment.
See my comments in Encounter influenza admin 1 regarding missing MS elements reasonCode, reasonReference and location.
| "start": "2023-04-11T09:20:00+10:00", | ||
| "end": "2023-04-11T09:35:00+10:00" | ||
| }, | ||
| "serviceProvider": { |
There was a problem hiding this comment.
See my comments in Encounter influenza admin 1 regarding missing MS elements reasonCode, reasonReference and location.
| "code": "AMB", | ||
| "display": "ambulatory" | ||
| }, | ||
| "type": [ |
There was a problem hiding this comment.
Suggest type is removed for 2 reasons:
- type is not MS or mandatory
- Vaccinia is a Smallpox immunization and the serviceType/id/file name suggest this is an Influenza vaccination encounter.
| "code": "AMB", | ||
| "display": "ambulatory" | ||
| }, | ||
| "type": [ |
There was a problem hiding this comment.
Suggest type is removed for 2 reasons:
- type is not MS or mandatory
- Vaccinia is a Smallpox immunization and the serviceType/id/file name suggest this is an Influenza vaccination encounter.
| "period": { | ||
| "start": "2024-04-11T09:20:00+10:00", | ||
| "end": "2024-04-11T09:35:00+10:00" | ||
| }, |
There was a problem hiding this comment.
See my comments in Encounter influenza admin 1 regarding missing MS elements reasonCode, reasonReference and location.
| "reference": "Location/elimbah-medical-centre" | ||
| }, | ||
| "manufacturer": { | ||
| "display": "sanofi-aventis australia pty ltd" |
There was a problem hiding this comment.
Manufacturer is not MS, recommend element is removed from examples.
If the use of the element has justification, then recommend title case 'Sanofi-Aventis Australia' as per https://immunisationhandbook.health.gov.au/vaccines/fluquadri
| "display": "sanofi-aventis australia pty ltd" | ||
| }, | ||
| "lotNumber": "FLU2022A01", | ||
| "site": { |
There was a problem hiding this comment.
site has not been defined in AU CORE as an MS element. Please provide justification for inclusion in examples or remove the element.
| ], | ||
| "text": "Left upper arm" | ||
| }, | ||
| "performer": [ |
There was a problem hiding this comment.
Immunization.performer is not MS. Consider whether this is required in the example.
| } | ||
| } | ||
| ], | ||
| "protocolApplied": [ |
There was a problem hiding this comment.
AU Core doesn't define how to represent protocol applied by a provider in an Immunisation record. Consider whether this is required in the example.
| @@ -0,0 +1,89 @@ | |||
| { | |||
There was a problem hiding this comment.
Please see my comments on Immunization-influenza-1 - they all apply to this example.
| @@ -0,0 +1,89 @@ | |||
| { | |||
There was a problem hiding this comment.
Please see my comments on Immunization-influenza-1 - they all apply to this example.
| @@ -0,0 +1,89 @@ | |||
| { | |||
There was a problem hiding this comment.
Please see my comments on Immunization-influenza-1 - they all apply to this example.
| @@ -0,0 +1,89 @@ | |||
| { | |||
There was a problem hiding this comment.
Please see my comments on Immunization-influenza-1 - they all apply to this example.
| @@ -0,0 +1,89 @@ | |||
| { | |||
There was a problem hiding this comment.
Please see my comments on Immunization-influenza-1 - they all apply to this example.
| @@ -0,0 +1,89 @@ | |||
| { | |||
There was a problem hiding this comment.
Please see my comments on Immunization-influenza-1 - they all apply to this example.
mjosborne1
left a comment
mjosborne1
left a comment
There was a problem hiding this comment.
Please see my inline comments.
This is a task you requested when I was in Sparked so started it before I finished up, sent the PR and just remembered about it :) |
AU Core, per the profile on the resources. |
|
As the test data files have been moved to the the relevant directories (au-core, au-patient-summary etc), I've moved these also. |
5 participants
Added 7 influenza Immunization resources to patients of interest, including notes.
Added the associated Encounter resources for those immunization administrations.
Added notes to 3 of the existing AllergyIntolerance resources for patients of interest.