Skip to content

Conversation

@rcarmo
Copy link

@rcarmo rcarmo commented May 3, 2025

I fixed #489 by doing two passes over segments when converting and making sure things are collinear. It works for the simple initial case - I cannot get at the sample files that were linked later.

image

@hlorus
Copy link
Owner

hlorus commented May 4, 2025

The problem with this approach is that curves with a very fine resolution will also have lines that are almost co-linear. This can be provoked by creating a simple circle and setting the "Mesh Curve Resolution" setting in the sketcher panel to a high number, like 200.

@rcarmo
Copy link
Author

rcarmo commented May 4, 2025

Well, I could try to check if I'm walking through a circle.

@hlorus
Copy link
Owner

hlorus commented May 4, 2025

There's still an error when applying the steps described before:

ValueError: verts: found the same (BMVert) used multiple times
Error: Python: Traceback (most recent call last):
File "/home/yoga/Dropbox/blend/extensions/CAD_Sketcher/operators/set_sketch.py", line 20, in execute
return activate_sketch(context, self.index, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/yoga/Dropbox/blend/extensions/CAD_Sketcher/operators/utilities.py", line 148, in activate_sketch
update_convertor_geometry(context.scene, sketch=last_sketch)
File "/home/yoga/Dropbox/blend/extensions/CAD_Sketcher/converters.py", line 238, in update_convertor_geometry
mesh = mesh_from_temporary(
^^^^^^^^^^^^^^^^^^^^
File "/home/yoga/Dropbox/blend/extensions/CAD_Sketcher/converters.py", line 143, in mesh_from_temporary
bmesh.ops.dissolve_verts(bm, verts=edges_to_dissolve)

Also, just as a note: Ideally we would get that is_curve flag from the entity, maybe through attributes.

@rcarmo
Copy link
Author

rcarmo commented May 4, 2025

Hmm. I'm not getting that here. What Blender are you running, just for comparison? And can you share a test file?

@hlorus
Copy link
Owner

hlorus commented May 5, 2025

Blender 4.4. This is a simple testfile where it happens when i leave the sketch:
circle-resolution.zip
(Just change the file ending from .zip to .blend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Extra edges and vertices when converting to filled mesh

2 participants