Skip to content

AMP-203 Added separate object for week commencing#106

Merged
vineetkapoor-hmcts merged 8 commits intomainfrom
feature/AMP-203_weekcomencing
Feb 11, 2026
Merged

AMP-203 Added separate object for week commencing#106
vineetkapoor-hmcts merged 8 commits intomainfrom
feature/AMP-203_weekcomencing

Conversation

@vineetkapoor-hmcts
Copy link
Contributor

@vineetkapoor-hmcts vineetkapoor-hmcts commented Feb 10, 2026

  • Added separate object for week commencing in open api spec
  • Spec showing different example: Allocated Hearing and Week Commencing Hearing
  • Added Json annotation to ignore null fields

@vineetkapoor-hmcts vineetkapoor-hmcts requested a review from a team as a code owner February 10, 2026 14:14
"properties": {
"startDate": {
"description": "Proposed hearing week start date",
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be type string format date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked this on cp side and its a string

},
"endDate": {
"description": "One week calculated end date",
"type": "string",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be type string format date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked this on cp side and its a string

"courtHouse": {
"description": "Court house details ref id",
"type": "string",
"pattern": "[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a uuid? in which case type:string format:uuid?

sittingEnd: "2025-03-25T12:00:00Z"
judiciaryId: "123e4567-e89b-12d3-a456-426614174000"
courtHouse: "223e4567-e89b-12d3-a456-426614174111"
courtRoom: "223e4567-e89b-12d3-a456-426614174111"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make it different from courtHouse to avoid any possible coinfusion ?
I use alias to generate uuid on mac
uuidgen | awk '{ print tolower($1) }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of my friend's website uuidgenerator.net

startDate:
description: "Proposed hearing week start Date"
type: string
example: "2026-02-16"
Copy link
Contributor

@coling01 coling01 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same ... format date ... uuid etc down below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked this on cp side and its a string

description: "Number of week(s) hearing is proposed for"
type: integer
example: 1
weekCommencing:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"courtSittings": [] // Always empty is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted to clarify this with Deb first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in the example.
Note: courtSittings is not part of new object i.e weekCommencing

Copy link
Contributor

@samirgarg samirgarg Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not generate random tags. It needs to be added at top. Name it Court Schedule

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@vineetkapoor-hmcts vineetkapoor-hmcts merged commit fca1f78 into main Feb 11, 2026
15 checks passed
@vineetkapoor-hmcts vineetkapoor-hmcts deleted the feature/AMP-203_weekcomencing branch February 11, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants