Feature/sscs 10722 migration tool performance improvements #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss-evoco
previously approved these changes
Jul 27, 2022
| executorService); | ||
|
|
||
| executorService.shutdown(); | ||
| executorService.awaitTermination(Integer.MAX_VALUE, TimeUnit.DAYS); |
There was a problem hiding this comment.
Thats a worryingly long time to wait. Should we not have a smaller timeout (or configurable) ?
There was a problem hiding this comment.
This is just to make sure all the threads have finished before the executor service shuts them down, can reduce it, though
There was a problem hiding this comment.
After our conversation, I think this is fine.
ss-evoco
previously approved these changes
Jul 28, 2022
damien-cooke
previously approved these changes
Jul 29, 2022
dattipoeHMCTS
force-pushed
the
feature/sscs-10722-migration-tool-performance-improvements
branch
from
f39f8d8 to
9697f05
Compare
ss-evoco
previously approved these changes
Oct 10, 2022
- tidied code - added timer for performance metrics - added support for multi-threading via parallel streams - updated tests
- improved date logic - runner text formatting changes
- improved case fetching logic - streamlined logic for using parallel stream
alberto-hortiguela
force-pushed
the
feature/sscs-10722-migration-tool-performance-improvements
branch
from
4dad189 to
64b85b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")