SPRDT-660 reworked implementation#123
Open
rajasekharkunchala wants to merge 4 commits intoteam/cct-1981from
Open
SPRDT-660 reworked implementation#123rajasekharkunchala wants to merge 4 commits intoteam/cct-1981from
rajasekharkunchala wants to merge 4 commits intoteam/cct-1981from
Conversation
| List<Map<String, Object>> courtList = new ArrayList<>(); | ||
| for (Map<String, Object> readyCase : readyCases) { | ||
| Map<String, Object> entry = new LinkedHashMap<>(); | ||
| entry.put("caseUrn", readyCase.get("caseUrn")); |
Collaborator
There was a problem hiding this comment.
check the source and see if it's strongly typed.
| # Set to false to disable SJP publish to CaTH (e.g. in envs where SJP is not used) | ||
| cath: | ||
| sjp: | ||
| publishing-enabled: ${CATH_SJP_PUBLISHING_ENABLED:true} |
Collaborator
There was a problem hiding this comment.
maybe scheduler will be the driver?
| import uk.gov.hmcts.cp.openapi.model.CourtListPublishResponse; | ||
| import uk.gov.hmcts.cp.openapi.model.CourtListType; | ||
| import uk.gov.hmcts.cp.openapi.model.PublishCourtListRequest; | ||
| import uk.gov.hmcts.cp.openapi.model.PublishCourtListResponse; |
Collaborator
There was a problem hiding this comment.
add proper in-container integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/SPRDT-660
Change description
Move sjp pubhub functionality to new publishing service
Does this PR introduce a breaking change? (check one with "x")