Conversation
src/main/java/uk/gov/hmcts/cp/services/BaseCourtListTransformationService.java
Fixed
Show fixed
Hide fixed
src/main/java/uk/gov/hmcts/cp/services/OnlinePublicCourtListTransformationService.java
Fixed
Show fixed
Hide fixed
src/main/java/uk/gov/hmcts/cp/services/OnlinePublicCourtListTransformationService.java
Fixed
Show fixed
Hide fixed
src/main/java/uk/gov/hmcts/cp/services/StandardCourtListTransformationService.java
Fixed
Show fixed
Hide fixed
src/main/java/uk/gov/hmcts/cp/services/StandardCourtListTransformationService.java
Fixed
Show fixed
Hide fixed
| AZURE_STORAGE_ENABLED: "true" | ||
| AZURE_STORAGE_CONTAINER_NAME: courtpublisher-blob-container | ||
| AZURE_STORAGE_ACCOUNT_NAME: "devstoreaccount1" | ||
| AZURE_STORAGE_ACCOUNT_KEY: "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==" |
There was a problem hiding this comment.
hey Arcadius ... line58 is a typical line that is blocking your merge.
Sadly there are 18 secrets embedded somewhere in the 170 commits in this PR.
It would be very tricky to weed them out. Which means we dont know what they are.
SO I DONT THINK YOU SHOULD MERGE IT AS IS
I propose that we should
a) Copy the code from this branch into a new branch without any of the history.
This drops 17 of the secrets, leaves just AZURE_STORAGE_ACCOUNT_KEY=Eby8.
b) Add AZURE_STORAGE_ACCOUNT_KEY as a variable in the github repository with the Eby8 value
( it can be a variable because we know its not secret )
c) In the ci-build-publish pull in the variable and expose it
i.e.
env:
AZURE_STORAGE_ACCOUNT_KEY: ${{ vars.AZURE_STORAGE_ACCOUNT_KEY }}
I tried to push a branch to show but I have no permissions on your repo.
I think the only other option, a BETTER option would be to work out how to use a custom key in the azure emulator and not have to use the Eby8 one. I could not work it out but feel it should be possible.
c3484ab to
a50520b
Compare
d44a859 to
f2ebf99
Compare
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")