Skip to content

Team/cct 1981 release#128

Open
arcadiushmcts wants to merge 1 commit intomainfrom
team/cct-1981-release
Open

Team/cct 1981 release#128
arcadiushmcts wants to merge 1 commit intomainfrom
team/cct-1981-release

Conversation

@arcadiushmcts
Copy link
Collaborator

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

AZURE_STORAGE_ENABLED: "true"
AZURE_STORAGE_CONTAINER_NAME: courtpublisher-blob-container
AZURE_STORAGE_ACCOUNT_NAME: "devstoreaccount1"
AZURE_STORAGE_ACCOUNT_KEY: "Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw=="
Copy link

@coling01 coling01 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey Arcadius ... line58 is a typical line that is blocking your merge.

Sadly there are 18 secrets embedded somewhere in the 170 commits in this PR.
It would be very tricky to weed them out. Which means we dont know what they are.
SO I DONT THINK YOU SHOULD MERGE IT AS IS

I propose that we should
a) Copy the code from this branch into a new branch without any of the history.
This drops 17 of the secrets, leaves just AZURE_STORAGE_ACCOUNT_KEY=Eby8.

b) Add AZURE_STORAGE_ACCOUNT_KEY as a variable in the github repository with the Eby8 value
( it can be a variable because we know its not secret )

c) In the ci-build-publish pull in the variable and expose it
i.e.
env:
AZURE_STORAGE_ACCOUNT_KEY: ${{ vars.AZURE_STORAGE_ACCOUNT_KEY }}

I tried to push a branch to show but I have no permissions on your repo.

I think the only other option, a BETTER option would be to work out how to use a custom key in the azure emulator and not have to use the Eby8 one. I could not work it out but feel it should be possible.

@arcadiushmcts arcadiushmcts force-pushed the team/cct-1981-release branch from c3484ab to a50520b Compare March 19, 2026 16:21
@arcadiushmcts arcadiushmcts force-pushed the team/cct-1981-release branch from d44a859 to f2ebf99 Compare March 19, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants