DMP-5252 ARM 5.2 upgrade #3088
Open
DMP-5252 ARM 5.2 upgrade #3088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-hedges
force-pushed
the
DMP-5252-ARM-5-2-Upgrade
branch
from
99ed2fd to
01e8d70
Compare
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-3088
labels
karen-hedges
requested review from
DavidTMann,
cakeben and
jackmaloney
and removed request for
a team
DavidTMann
reviewed
Oct 10, 2025
src/main/java/uk/gov/hmcts/darts/arm/service/impl/ArmClientServiceImpl.java
Show resolved
Hide resolved
karen-hedges
force-pushed
the
DMP-5252-ARM-5-2-Upgrade
branch
from
db9140b to
ea61d86
Compare
No. This already encompassed in the automted jobs where it checks how many times something has been tried.
We have logs for all of this already. The code I'm touching is very low down.
Just adding some |
DavidTMann
reviewed
Oct 13, 2025
...egrationTest/java/uk/gov/hmcts/darts/arm/service/ArmRpoPollServiceUpgradeFiveTwoIntTest.java
Outdated
Show resolved
Hide resolved
DavidTMann
approved these changes
Oct 13, 2025
stephenokeefe
requested changes
Oct 13, 2025
src/main/java/uk/gov/hmcts/darts/arm/service/impl/ArmApiServiceImpl.java
Outdated
Show resolved
Hide resolved
stephenokeefe
approved these changes
Oct 13, 2025
karen-hedges
force-pushed
the
DMP-5252-ARM-5-2-Upgrade
branch
from
3beb05d to
dcc1d0b
Compare
karen-hedges
force-pushed
the
DMP-5252-ARM-5-2-Upgrade
branch
from
68d9537 to
c0f196e
Compare
Made changes to conform to the ARM 5.2 upgrade where auth and api are replacing the www part of hostname and respecitively removed from the rest of the URL
Started to move the ARM clients into a service so the current version and new version can be enabled accordingly
Started to move the ARM clients into a service so the current version and new version can be enabled accordingly
Started to move the ARM clients into a service so the current version and new version can be enabled accordingly
Started to move the ARM clients into a service so the current version and new version can be enabled accordingly
Started to move the ARM clients into a service so the current version and new version can be enabled accordingly
Added tests
Added tests
Added tests
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added open apid validation
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
Added no sonar to fix sonar complaint of duplicate code
karen-hedges
force-pushed
the
DMP-5252-ARM-5-2-Upgrade
branch
from
c0f196e to
b89ff74
Compare
Added no sonar to fix sonar complaint of duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-5252
Change description
Made changes to conform to the ARM 5.2 upgrade where auth and api are replacing the www part of hostname and respectively removed from the rest of the URL
Does this PR introduce a breaking change? (check one with "x")