- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3
Dmp 5276 openapi validator #3091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d9d0750    to
    d5d5945      
    Compare
  
    | To enable OpenAPI validation, the following properties are set in the application configuration: | ||
| ```bash | ||
| lint-openapi "src/main/resources/openapi/**/*.yaml" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is doing linting similar to spectral rather than any validation against requests/responses, we need to decide whether to use lint-openapi or spectral for linting (we need spectral anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint-openapi uses spectral
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is using lint-openapi giving any benefit over just using spectral? e.g. spectral lint --verbose "src/main/resources/openapi/**/*.{yml,yaml}"
It seems duplicated in their purpose. Both are mentioned in the readme, but both are doing the same thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenAPI validator is better than spectral and can use the spectral ruleset
31e4539    to
    a2a1964      
    Compare
  
    …-api Added spectral config
Added open apid validation
Added open apid validation
Added open apid validation
Added open api validation
Added open apid validation
Added open api validation
Added open api validation
Added open api validation
a2a1964    to
    7348afb      
    Compare
  
    
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-5276
Change description
Added open API validation
Does this PR introduce a breaking change? (check one with "x")