Skip to content

DMP-5287 Create new index to improve retention performance #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DMP-5287 Create new index to improve retention performance #3092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c26d669
DMP-5287 Create new index to improve retention performance
karen-hedges Oct 11, 2025
7607a0d
DMP-5287 Create new index to improve retention performance
karen-hedges Oct 23, 2025
44c978c
DMP-5287 Create new index to improve retention performance
karen-hedges Oct 29, 2025
71fbd5f
DMP-5287 Create new index to improve retention performance
karen-hedges Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/integrationTest/java/uk/gov/hmcts/darts/cases/repository/CaseRepositoryIntTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class CaseRepositoryIntTest extends IntegrationBase {
private CaseRepository caseRepository;

@Test
void findByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_ReturnsResults() {
void findByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_ShouldReturnsResults() {
// given
caseStub.createAndSaveCourtCase(courtCase -> {
courtCase.setRetentionUpdated(true);
Expand Down Expand Up @@ -69,7 +69,7 @@ void findByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_ReturnsResults() {
}

@Test
void findIdsByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_caseHasNoAssocaitedCaseRetentionEntity_shouldNotReturn() {
void findIdsByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_ShouldNotReturn_WhenCaseHasNoAssociatedCaseRetentionEntity() {
// given
caseStub.createAndSaveCourtCase(courtCase -> {
courtCase.setRetentionUpdated(true);
Expand All @@ -82,7 +82,7 @@ void findIdsByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_caseHasNoAssocai
}

@Test
void findIdsByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_oneCaseHasMultipleRetentionObjects_shouldOnlyReturnIdOnce() {
void findIdsByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_ShouldOnlyReturnIdOnce_WhereOneCaseHasMultipleRetentionObjects() {
// given
var matchingCase = caseStub.createAndSaveCourtCase(courtCase -> {
courtCase.setRetentionUpdated(true);
Expand All @@ -106,7 +106,7 @@ void findIdsByIsRetentionUpdatedTrueAndRetentionRetriesLessThan_oneCaseHasMultip


@Test
void findCasesIdsNeedingCaseDocumentGenerated_ReturnsMatchingCases() {
void findCasesIdsNeedingCaseDocumentGenerated_ShouldReturnsMatchingCases() {
// given
caseStub.createAndSaveCourtCase(courtCase -> {
courtCase.setClosed(true);
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/uk/gov/hmcts/darts/common/repository/CaseRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ AND NOT EXISTS (select 1 from CaseRetentionEntity cre
""")
List<Integer> findOpenCasesToClose(OffsetDateTime cutoffDate, Limit limit);

// Must have join to case retention to ensure all cases returned have CaseRetentionEntity
@Query("""
SELECT distinct cc.id
FROM CourtCaseEntity cc
JOIN cc.caseRetentionEntities cr
WHERE cr is not null
AND cc.isRetentionUpdated = true
JOIN cc.caseRetentionEntities cr
WHERE cc.isRetentionUpdated = true
AND cc.retentionRetries < :maxRetentionRetries
ORDER BY cc.id ASC
""")
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/db/migration/postgres/V1_489__create_new_indexes.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CREATE INDEX IF NOT EXISTS cr_rr_idx ON case_retention (retention_retries);