Fix: Decrease time taken running MediaKind unit tests #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running all tests should now be 6x quicker
lydiaralphgov
previously approved these changes
Jun 6, 2025
Plan Result (stg)
Change Result (Click me) # module.pre-api-exception-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/74dacd4f-a248-45bb-a2f0-af700dc4cf68/resourceGroups/pre-stg/providers/Microsoft.Resources/deployments/PRE_API_exception"
name = "PRE_API_exception"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy. |
Plan Result (prod)
Change Result (Click me) # module.pre-api-exception-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Resources/deployments/PRE_API_exception"
name = "PRE_API_exception"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.pre-api-liveness-alert[0].azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/5ca62022-6aa2-4cee-aaa7-e7536c8d566c/resourceGroups/pre-prod/providers/Microsoft.Resources/deployments/PRE_API_liveness"
name = "PRE_API_liveness"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy. |
jasonpaige
previously approved these changes
Jul 8, 2025
# Conflicts: # src/main/java/uk/gov/hmcts/reform/preapi/media/MediaKind.java
lucas-phillips28
dismissed stale reviews from jasonpaige and lydiaralphgov
via
5f69668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
MediaKind.javaso its slightly more readable