Skip to content

Remove logging dependencies #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove logging dependencies #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74d8978
Remove logging dependencies
Michael1142 Jun 21, 2025
643f982
Change workflow name
Michael1142 Jun 21, 2025
0ab15e1
Remove pined snakeyaml version as 2.4 is compatible
Michael1142 Jun 21, 2025
37f365b
Use java 21 for github actions
Michael1142 Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Template CI
name: Java CI

on:
pull_request:
Expand All @@ -16,7 +16,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin' # See 'Supported distributions' for available options
java-version: '17'
java-version: '21'
cache: 'gradle'
- name: Build
run: ./gradlew check
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: 'temurin' # See 'Supported distributions' for available options
java-version: '17'
java-version: '21'


# Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ jobs:
SWAGGER_PUBLISHER_API_TOKEN: ${{ secrets.SWAGGER_PUBLISHER_API_TOKEN }}
with:
test_to_run: 'uk.gov.hmcts.reform.demo.openapi.OpenAPIPublisherTest'
java_version: 17
java_version: '21'
12 changes: 0 additions & 12 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,6 @@ repositories {
}
}

ext {
log4JVersion = "2.25.0"
logbackVersion = "1.5.18"
}

ext['snakeyaml.version'] = '2.0'

dependencies {
implementation group: 'org.springframework.boot', name: 'spring-boot-starter-web'
implementation group: 'org.springframework.boot', name: 'spring-boot-starter-actuator'
Expand All @@ -148,11 +141,6 @@ dependencies {

implementation group: 'com.github.hmcts.java-logging', name: 'logging', version: '6.1.9'

implementation group: 'org.apache.logging.log4j', name: 'log4j-api', version: log4JVersion
implementation group: 'org.apache.logging.log4j', name: 'log4j-to-slf4j', version: log4JVersion
implementation group: 'ch.qos.logback', name: 'logback-classic', version: logbackVersion
implementation group: 'ch.qos.logback', name: 'logback-core', version: logbackVersion

testImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-test'
testImplementation group: 'io.rest-assured', name: 'rest-assured', version: '5.5.5'
}
Expand Down