Skip to content

RWA-4661: Added new test case for complete #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

RWA-4661: Added new test case for complete #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c3029c2
RWA-4661: Added new test case for complete
adityadwadasi Aug 29, 2025
516bedf
Merge branch 'master' into RWA-4661_complete_int_test
adityadwadasi Sep 2, 2025
9fa9bde
Merge branch 'master' into RWA-4661_complete_int_test
adityadwadasi Oct 6, 2025
ded224f
Updated the test name
adityadwadasi Oct 6, 2025
64bb880
Added history table assertions.
adityadwadasi Oct 6, 2025
8ab0343
Merge branch 'master' into RWA-4661_complete_int_test
adityadwadasi Oct 13, 2025
fa583ed
Merge branch 'master' into RWA-4661_complete_int_test
adityadwadasi Oct 15, 2025
31eaabf
Test refactor
adityadwadasi Oct 16, 2025
6f32882
Updated the Assertions
adityadwadasi Oct 17, 2025
263b816
Merge branch 'master' into RWA-4661_complete_int_test
adityadwadasi Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
329 changes: 329 additions & 0 deletions ...cts/reform/wataskmanagementapi/controllers/PostTaskCompleteByIdControllerReplicaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,329 @@
package uk.gov.hmcts.reform.wataskmanagementapi.controllers;

import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.mockito.Mock;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.test.annotation.DirtiesContext;
import org.springframework.test.context.ActiveProfiles;
import org.springframework.test.context.bean.override.mockito.MockitoBean;
import uk.gov.hmcts.reform.authorisation.ServiceAuthorisationApi;
import uk.gov.hmcts.reform.authorisation.generators.AuthTokenGenerator;
import uk.gov.hmcts.reform.wataskmanagementapi.auth.access.AccessControlService;
import uk.gov.hmcts.reform.wataskmanagementapi.auth.access.entities.AccessControlResponse;
import uk.gov.hmcts.reform.wataskmanagementapi.auth.idam.IdamService;
import uk.gov.hmcts.reform.wataskmanagementapi.auth.idam.entities.Token;
import uk.gov.hmcts.reform.wataskmanagementapi.auth.idam.entities.UserInfo;
import uk.gov.hmcts.reform.wataskmanagementapi.auth.restrict.ClientAccessControlService;
import uk.gov.hmcts.reform.wataskmanagementapi.auth.role.entities.RoleAssignment;
import uk.gov.hmcts.reform.wataskmanagementapi.auth.role.entities.response.RoleAssignmentResource;
import uk.gov.hmcts.reform.wataskmanagementapi.clients.CamundaServiceApi;
import uk.gov.hmcts.reform.wataskmanagementapi.clients.IdamWebApi;
import uk.gov.hmcts.reform.wataskmanagementapi.clients.RoleAssignmentServiceApi;
import uk.gov.hmcts.reform.wataskmanagementapi.config.LaunchDarklyFeatureFlagProvider;
import uk.gov.hmcts.reform.wataskmanagementapi.config.features.FeatureFlag;
import uk.gov.hmcts.reform.wataskmanagementapi.controllers.request.CompleteTaskRequest;
import uk.gov.hmcts.reform.wataskmanagementapi.domain.enums.TestRolesWithGrantType;
import uk.gov.hmcts.reform.wataskmanagementapi.entity.ReportableTaskResource;
import uk.gov.hmcts.reform.wataskmanagementapi.entity.TaskHistoryResource;
import uk.gov.hmcts.reform.wataskmanagementapi.entity.TaskResource;
import uk.gov.hmcts.reform.wataskmanagementapi.entity.TaskRoleResource;
import uk.gov.hmcts.reform.wataskmanagementapi.enums.TaskAction;
import uk.gov.hmcts.reform.wataskmanagementapi.services.CFTTaskDatabaseService;
import uk.gov.hmcts.reform.wataskmanagementapi.services.ReplicaBaseTest;
import uk.gov.hmcts.reform.wataskmanagementapi.utils.ServiceMocks;
import uk.gov.hmcts.reform.wataskmanagementapi.utils.TaskTestUtils;

import java.time.Duration;
import java.time.LocalDate;
import java.time.LocalTime;
import java.time.OffsetDateTime;
import java.time.ZoneId;
import java.time.temporal.ChronoUnit;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import java.util.UUID;

import static java.util.concurrent.TimeUnit.SECONDS;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.within;
import static org.awaitility.Awaitility.await;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.lenient;
import static org.mockito.Mockito.when;
import static org.springframework.http.MediaType.APPLICATION_JSON_VALUE;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
import static uk.gov.hmcts.reform.wataskmanagementapi.cft.enums.CFTTaskState.COMPLETED;
import static uk.gov.hmcts.reform.wataskmanagementapi.cft.enums.CFTTaskState.UNASSIGNED;
import static uk.gov.hmcts.reform.wataskmanagementapi.config.SecurityConfiguration.AUTHORIZATION;
import static uk.gov.hmcts.reform.wataskmanagementapi.config.SecurityConfiguration.SERVICE_AUTHORIZATION;
import static uk.gov.hmcts.reform.wataskmanagementapi.utils.ServiceMocks.IDAM_AUTHORIZATION_TOKEN;
import static uk.gov.hmcts.reform.wataskmanagementapi.utils.ServiceMocks.IDAM_OTHER_USER_ID;
import static uk.gov.hmcts.reform.wataskmanagementapi.utils.ServiceMocks.IDAM_USER_EMAIL;
import static uk.gov.hmcts.reform.wataskmanagementapi.utils.ServiceMocks.IDAM_USER_ID;
import static uk.gov.hmcts.reform.wataskmanagementapi.utils.ServiceMocks.SERVICE_AUTHORIZATION_TOKEN;

@ActiveProfiles("replica")
@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_CLASS)
@Slf4j
public class PostTaskCompleteByIdControllerReplicaTest extends ReplicaBaseTest {

private static final String ENDPOINT_PATH = "/task/%s/complete";
private static String ENDPOINT_BEING_TESTED;

@MockitoBean
LaunchDarklyFeatureFlagProvider launchDarklyFeatureFlagProvider;

@MockitoBean
private AuthTokenGenerator authTokenGenerator;

@MockitoBean
private IdamWebApi idamWebApi;
@MockitoBean
private CamundaServiceApi camundaServiceApi;
@MockitoBean
private RoleAssignmentServiceApi roleAssignmentServiceApi;
@MockitoBean
private ServiceAuthorisationApi serviceAuthorisationApi;
@Autowired
private CFTTaskDatabaseService cftTaskDatabaseService;
@MockitoBean
private IdamService idamService;
@MockitoBean
private AccessControlService accessControlService;
@MockitoBean
private ClientAccessControlService clientAccessControlService;

@Mock
private UserInfo mockedUserInfo;

private ServiceMocks mockServices;

TaskTestUtils taskTestUtils;

@BeforeAll
void init() {
taskTestUtils = new TaskTestUtils(cftTaskDatabaseService,"replica");
}

@Test
void should_update_reportable_task_values_when_complete_api_invoked() throws Exception {

final String taskId = UUID.randomUUID().toString();

when(clientAccessControlService.hasPrivilegedAccess(eq(SERVICE_AUTHORIZATION_TOKEN), any()))
.thenReturn(false);

lenient().when(launchDarklyFeatureFlagProvider.getBooleanValue(eq(FeatureFlag.WA_COMPLETION_PROCESS_UPDATE),
anyString(), anyString())).thenReturn(false);
when(authTokenGenerator.generate())
.thenReturn(IDAM_AUTHORIZATION_TOKEN);
lenient().when(mockedUserInfo.getUid())
.thenReturn(IDAM_USER_ID);
lenient().when(mockedUserInfo.getEmail())
.thenReturn(IDAM_USER_EMAIL);

mockServices = new ServiceMocks(
idamWebApi,
serviceAuthorisationApi,
camundaServiceApi,
roleAssignmentServiceApi
);

mockServices.mockUserInfo();

RoleAssignmentRequest roleAssignmentRequest = RoleAssignmentRequest.builder()
.testRolesWithGrantType(TestRolesWithGrantType.STANDARD_TRIBUNAL_CASE_WORKER_PUBLIC)
.roleAssignmentAttribute(
RoleAssignmentAttribute.builder()
.jurisdiction("IA")
.caseType("Asylum")
.caseId("completeCaseId1")
.build()
)
.build();

List<RoleAssignment> roleAssignments = new ArrayList<>();

createRoleAssignment(roleAssignments, roleAssignmentRequest);

final RoleAssignmentResource accessControlResponse = new RoleAssignmentResource(roleAssignments);



TaskRoleResource taskRoleResource = new TaskRoleResource(
TestRolesWithGrantType.STANDARD_TRIBUNAL_CASE_WORKER_PUBLIC.getRoleName(),
true, true, true, false, false, false,
new String[]{}, 1, false,
TestRolesWithGrantType.STANDARD_TRIBUNAL_CASE_WORKER_PUBLIC.getRoleCategory().name()
);

taskRoleResource.setComplete(true);

when(idamService.getUserInfo(IDAM_AUTHORIZATION_TOKEN)).thenReturn(mockedUserInfo);
when(roleAssignmentServiceApi.getRolesForUser(
any(), any(), any()
)).thenReturn(accessControlResponse);
when(accessControlService.getRoles(IDAM_AUTHORIZATION_TOKEN))
.thenReturn(new AccessControlResponse(mockedUserInfo, roleAssignments));

lenient().when(mockedUserInfo.getUid())
.thenReturn(IDAM_OTHER_USER_ID);
when(idamWebApi.token(any())).thenReturn(new Token(IDAM_AUTHORIZATION_TOKEN, "scope"));
when(serviceAuthorisationApi.serviceToken(any())).thenReturn(SERVICE_AUTHORIZATION_TOKEN);

doNothing().when(camundaServiceApi).assignTask(any(), any(), any());
doNothing().when(camundaServiceApi).addLocalVariablesToTask(any(), any(), any());

taskTestUtils.insertDummyTaskInDb("IA", "Asylum", "completeCaseId1",
taskId,UNASSIGNED, taskRoleResource,null, IDAM_USER_ID);

ENDPOINT_BEING_TESTED = String.format(ENDPOINT_PATH, taskId);

CompleteTaskRequest request = new CompleteTaskRequest(null);
mockMvc.perform(
post(ENDPOINT_BEING_TESTED)
.header(AUTHORIZATION, IDAM_AUTHORIZATION_TOKEN)
.header(SERVICE_AUTHORIZATION, SERVICE_AUTHORIZATION_TOKEN)
.contentType(APPLICATION_JSON_VALUE)
.content(asJsonString(request))
).andExpectAll(
status().isNoContent()
);

await()
.pollDelay(5, SECONDS)
.atMost(30, SECONDS)
.untilAsserted(() -> {
List<ReportableTaskResource> reportableTaskList2
= miReportingServiceForTest.findByReportingTaskId(taskId);
assertEquals(1, reportableTaskList2.size());
});

Optional<TaskResource> taskResourcePostComplete = cftTaskDatabaseService.findByIdOnly(taskId);

assertTrue(taskResourcePostComplete.isPresent());
assertEquals(COMPLETED, taskResourcePostComplete.get().getState());
assertEquals(IDAM_USER_ID, taskResourcePostComplete.get().getAssignee());
assertNotNull(taskResourcePostComplete.get().getLastUpdatedTimestamp());
assertEquals(IDAM_OTHER_USER_ID, taskResourcePostComplete.get().getLastUpdatedUser());
assertEquals(TaskAction.COMPLETED.getValue(), taskResourcePostComplete.get().getLastUpdatedAction());

await()
.pollDelay(3, SECONDS)
.atMost(30, SECONDS)
.untilAsserted(() -> {

List<TaskHistoryResource> taskHistoryResourceList
= miReportingServiceForTest.findByTaskId(taskId);

assertEquals(2, taskHistoryResourceList.size());
assertEquals("COMPLETED", taskHistoryResourceList.get(1).getState());
assertEquals(IDAM_USER_ID, taskHistoryResourceList.get(1).getAssignee());
assertEquals(IDAM_OTHER_USER_ID, taskHistoryResourceList.get(1).getUpdatedBy());
assertEquals("Complete", taskHistoryResourceList.get(1).getUpdateAction());

OffsetDateTime expected = OffsetDateTime.now();

assertThat(taskHistoryResourceList.get(1).getUpdated())
.isCloseTo(expected, within(1, ChronoUnit.MINUTES));

assertThat(taskHistoryResourceList.get(1).getCreated())
.isCloseTo(expected, within(1, ChronoUnit.MINUTES));

assertThat(taskHistoryResourceList.get(1).getDueDateTime())
.isCloseTo(expected.plusDays(1), within(1, ChronoUnit.MINUTES));
});

await()
.pollDelay(3, SECONDS)
.atMost(30, SECONDS)
.untilAsserted(() -> {

List<ReportableTaskResource> reportableTaskList
= miReportingServiceForTest.findByReportingTaskId(taskId);

assertEquals(1, reportableTaskList.size());
assertEquals("COMPLETED", reportableTaskList.get(0).getState());
assertNotNull(reportableTaskList.get(0).getAssignee());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Majority of assertNotNull assertions can use real values

assertEquals(IDAM_USER_ID, reportableTaskList.get(0).getAssignee());
assertNotNull(reportableTaskList.get(0).getUpdatedBy());
assertEquals(IDAM_OTHER_USER_ID, reportableTaskList.get(0).getUpdatedBy());

OffsetDateTime expected = OffsetDateTime.now();

assertThat(reportableTaskList.get(0).getUpdated())
.isCloseTo(expected, within(1, ChronoUnit.MINUTES));
assertEquals("Complete", reportableTaskList.get(0).getUpdateAction());

LocalDate today = LocalDate.now(ZoneId.systemDefault());

assertEquals(today, reportableTaskList.get(0).getCompletedDate()
.toInstant().atZone(ZoneId.systemDefault()).toLocalDate());
assertThat(reportableTaskList.get(0).getCompletedDateTime().toLocalDate())
.isEqualTo(expected.toLocalDate());
assertEquals(today, reportableTaskList.get(0).getCreatedDate()
.toInstant().atZone(ZoneId.systemDefault()).toLocalDate());

assertThat(reportableTaskList.get(0).getDueDate()
.toInstant()
.atZone(ZoneId.systemDefault())
.toLocalDate())
.isEqualTo(LocalDate.now().plusDays(1));

assertEquals(today, reportableTaskList.get(0).getLastUpdatedDate()
.toInstant().atZone(ZoneId.systemDefault()).toLocalDate());
assertEquals("COMPLETED", reportableTaskList.get(0).getFinalStateLabel());
assertEquals(today, reportableTaskList.get(0).getFirstAssignedDate()
.toInstant().atZone(ZoneId.systemDefault()).toLocalDate());
assertThat(reportableTaskList.get(0).getFirstAssignedDateTime())
.isCloseTo(expected, within(1, ChronoUnit.MINUTES));
Assertions.assertNull(reportableTaskList.get(0).getWaitTimeDays());
Assertions.assertNull(reportableTaskList.get(0).getWaitTime());
assertEquals(0, reportableTaskList.get(0).getHandlingTimeDays());

long seconds = 0;
LocalTime time = null;

String processingTime = reportableTaskList.get(0).getProcessingTime();
time = LocalTime.parse(processingTime);
seconds = Duration.between(LocalTime.MIDNIGHT, time).getSeconds();
assertTrue(seconds < 60,
String.format("Processing time %s exceeds 1 minute limit", processingTime));

String handlingTime = reportableTaskList.get(0).getHandlingTime();
time = LocalTime.parse(handlingTime);
seconds = Duration.between(LocalTime.MIDNIGHT, time).getSeconds();
assertTrue(seconds < 60,
String.format("Handling time %s exceeds 1 minute limit", processingTime));

assertEquals(0, reportableTaskList.get(0).getProcessingTimeDays());
assertEquals("Yes", reportableTaskList.get(0).getIsWithinSla());
assertEquals(0, reportableTaskList.get(0).getNumberOfReassignments());
assertEquals(-1, reportableTaskList.get(0).getDueDateToCompletedDiffDays());

String diffTime = reportableTaskList.get(0).getDueDateToCompletedDiffTime();
if (diffTime.contains("day")) {
int days = Integer.parseInt(diffTime.split(" ")[0]);
assertTrue(days <= 1,
String.format("Expected diff <= 1 day, but was %s", diffTime));
} else {
time = LocalTime.parse(diffTime);
assertTrue(time.isBefore(LocalTime.MIDNIGHT.minus(1, ChronoUnit.MILLIS)),
String.format("Expected time < 24h, but was %s", time));
}
});

}

}
Loading