RWA-4724: Decouple user creation in individual functional tests #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinYSpasov
requested changes
Oct 28, 2025
|
|
||
| public static final String EMAIL_PREFIX_GIN_INDEX = "wa-gin-index-"; | ||
|
|
||
| TestAuthenticationCredentials baseCaseworkerCredentials; |
There was a problem hiding this comment.
Do you need baseCaseworkerCredentials here?
| tribCaseworkerWithCompletionDisabled.getHeaders(),"tribunal-caseworker"); | ||
| testUsersMap.put(USER_WITH_TRIB_ROLE_COMPLETION_DISABLED,tribCaseworkerWithCompletionDisabled); | ||
|
|
||
| TestAuthenticationCredentials caseWorkerWithTribRoleWithWorkTypes = |
There was a problem hiding this comment.
We have multiple tribunal-caseworker with WAOrganisationalRoleAssignment do we really need them all?
| private static final String ENDPOINT_BEING_TESTED = "/task/task-types"; | ||
|
|
||
| @Before | ||
| public void setUp() { |
There was a problem hiding this comment.
Do we really need @before method here?
|
|
||
| private TestAuthenticationCredentials caseWorkerWithCftOrgRoles; | ||
|
|
||
| @Before |
There was a problem hiding this comment.
Do we need @before method here?
|
|
||
| private TestAuthenticationCredentials caseworkerWithNoRoles; | ||
|
|
||
| @Before |
There was a problem hiding this comment.
We have this @before method in few places , which I believe is uneccessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RWA-4724
Change description
Does this PR introduce a breaking change? (check one with "x")