Skip to content

CME-496: address pact test failures #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+9 −8
Open

CME-496: address pact test failures #521

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6a5dc4
CME-496: address pact test failures
kiran-yenigala-hmcts Jul 14, 2025
c545856
Merge branch 'master' into CME-496-1
kiran-yenigala-hmcts Aug 27, 2025
6851289
Merge branch 'master' into CME-496-1
kiran-yenigala-hmcts Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ...uk/gov/hmcts/reform/wataskmonitor/consumer/ccd/util/PactDslBuilderForCaseDetailsList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public static DslPart buildStartEventForCaseWorkerPactDsl(String eventId) {
return newJsonBody(o ->
o.stringType("event_id", eventId)
.stringType("token", "token")
.nullValue("token")
.stringValue("token", "")
.object("case_details", cd -> {
cd.numberType("id", 2000);
cd.stringMatcher("jurisdiction", ALPHABETIC_REGEX, "IA");
Expand All @@ -33,7 +33,7 @@ public static DslPart buildStartForCaseWorkerPactDsl(String eventId) {
return newJsonBody(
o -> o.stringType("event_id", eventId)
.stringType("token", "token")
.nullValue("token")
.stringValue("token", "")
.object("case_details", cd -> {
cd.stringMatcher("jurisdiction", ALPHABETIC_REGEX, "IA");
cd.stringMatcher("case_type_id", ALPHABETIC_REGEX, "Asylum");
Expand Down Expand Up @@ -85,16 +85,17 @@ private static void getCaseDataPactDsl(final LambdaDslObject dataMap) {
.stringType("uploadAddendumEvidenceLegalRepActionAvailable", "No")
.object("legalRepCompanyAddress", addr -> {
addr.stringType("AddressLine1", "AddressLine1")
.nullValue("AddressLine1");
.stringValue("AddressLine1", "");
addr.stringType("AddressLine2", "AddressLine2")
.nullValue("AddressLine2");
.stringValue("AddressLine2", "");
addr.stringType("AddressLine3", "AddressLine3")
.nullValue("AddressLine3");
.stringValue("AddressLine3", "");
addr.stringType("Country", "Country")
.nullValue("Country");
addr.stringType("PostCode", "");
.stringValue("Country", "");
addr.stringType("PostCode", "PostCode")
.stringValue("PostCode", "");
addr.stringType("PostTown", "PostTown")
.nullValue("PostTown");
.stringValue("PostTown", "");
})
.minArrayLike("uploadTheNoticeOfDecisionDocs", 1, 1,
docsUploaded ->
Expand Down