Skip to content

Typename resolving optimized #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisBenua wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Typename resolving optimized #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Factory/Factory/Key.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ private func globalIdentifier(for type: Any.Type) -> ObjectIdentifier {
return knownID
}
// this is what we're bypassing. extremely slow runtime function.
let name = String(reflecting: type)
let name = _typeName(type, qualified: true)
// magic happens here, if name is already known then get original key for it
let id = globalNameToIdentifierTable[name, default: requestedTypeID]
// and save it so we don't have to do this again
Expand Down
2 changes: 1 addition & 1 deletion Sources/FactoryKit/FactoryKit/Key.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ private func globalIdentifier(for type: Any.Type) -> ObjectIdentifier {
return knownID
}
// this is what we're bypassing. extremely slow runtime function.
let name = String(reflecting: type)
let name = _typeName(type, qualified: true)
// magic happens here, if name is already known then get original key for it
let id = globalNameToIdentifierTable[name, default: requestedTypeID]
// and save it so we don't have to do this again
Expand Down